|Re: [jakartaee-tck-dev] Preparing to hack with ReWrite...|
I'm not sure adding more tooling will fix anything (except making it more complicated by adding more tooling :)).
Good point, the additional `rewrite` tooling would be temporary
until we complete the TCK refactoring.
I have some issues on how the current tckrefactor build structure (e.g pom content), I have some changes in my branch with the servlet tck using arquilian. But I didn't to fix too many things in this branch as the merge/rebase will be an even worst nightmare for me :)Some content I have in mind which looks wrong (or I don't understand the reason) to my (long) Maven experience.Why having everything in <dependencies>  in parent pom, this mean by example servlet or jsp will have batch or jms as dependency?
+1 for removing the <dependencies>  from the parent pom.
+1 for removing m-enforcer-p  from sub-modules.Why having this section with m-enforcer-p  is every poms?
+1I don't understand the need of using of build-helper-m-p  in every poms? we probably only need to have the sources in the standard Maven location.
If your concern is about having a clean build (e.g no compile issue) in the tckrefactor branch if you need a volunteer I can have a try for the next few days.
+1, thank you!
 https://github.com/jakartaee/platform-tck/blob/89850312460cb270a13a059ad2e16f44154dfab1/pom.xml#L384 https://github.com/jakartaee/platform-tck/blob/89850312460cb270a13a059ad2e16f44154dfab1/webservices13/pom.xml#L40
On Sat, Nov 19, 2022 at 12:54 AM Scott Marlow <smarlow@xxxxxxxxxx> wrote:
I am finding that in order to use ReWrite  to make source changes in our `tckrefactor` branch, we need to first get to zero build failures. My `rewrite` topic branch  has some changes but more changes are needed to resolve build failures such as . My question for all of you is how can we best get the `tckrefactor` branch building cleanly?
Is there anything that I can do to help others to participate in the clean up?Scott
jakartaee-tck-dev mailing list
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/jakartaee-tck-dev
_______________________________________________ jakartaee-tck-dev mailing list jakartaee-tck-dev@xxxxxxxxxxx To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/jakartaee-tck-dev
Back to the top