Skip to main content
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [jakartaee-tck-dev] Jakarta Transaction signatures (maybe others)


On 22/06/20 8:00 pm, Tom Jenkinson wrote:
It might not be signficant for too long but for Jakarta Transactions I wonder if https://github.com/eclipse-ee4j/jakartaee-tck/blob/master/src/com/sun/ts/tests/signaturetest/signature-repository/jakarta.transaction.sig_1.2_se11 should be (and have been) 1.3 instead of 1.2 [1]? That said, I expect these se11 signatures will be updated to a 2.0 version.

Yes, we will be regenerating the signature files for jdk11 as _se11 and jta will be updated to the latest(2.0). The old signature files will be removed.

We have done the same for jdk8(se8) signature files as discussed below.




On Thu, 11 Jun 2020 at 19:32, Tom Jenkinson <tom.jenkinson@xxxxxxxxxx> wrote:


On Thu, 11 Jun 2020 at 19:22, Alwin Joseph <alwin.joseph@xxxxxxxxxx> wrote:


On 11/06/20 11:43 pm, Tom Jenkinson wrote:
Thanks Alwin. The java API shouldn't have changed from RC1 so an RC1 jar could be OK to use too though there is actually an RC2 that I just closed https://ci.eclipse.org/jta/job/NexusStaging%20-%20List,%20close,%20drop,%20release/33/console. I am not sure how long it will take to get to Maven central however there is a Jar in sonatype:

But do you need it to be in central? In which case (and if you want RC2) then it might need you to wait till content for RC2 gets there?
Not required. I can take it from sonatype. I presume the one in glassfish/modules/ is also the latest by now. This is just to make sure there is no difference in sig file with RC1.

It is most likely to be an older version of RC2 that was built using a staged version as I only redeployed very recently. That said the Java source code for the Jar should be the same in the version of RC2 that was used before so hopefully it won't cause signficant problems.



On Thu, 11 Jun 2020 at 19:02, Alwin Joseph <alwin.joseph@xxxxxxxxxx> wrote:

Sorry I missed [1], Looks like we had used RC1. I will regenerate and compare if there are any differences for jta sig file and update.

[1] https://repo1.maven.org/maven2/jakarta/transaction/jakarta.transaction-api/2.0.0-RC1/jakarta.transaction-api-2.0.0-RC1.jar

On 10/06/20 10:13 pm, Tom Jenkinson wrote:
I whatever you provided as [1] was not included in your message?


On Wed, 10 Jun 2020 at 16:03, Alwin Joseph <alwin.joseph@xxxxxxxxxx> wrote:

Hi Tom,

As of now we have generated new signature file to be run in JDK8 as jakarta.transaction.sig_2.0_se8(using [1],  Is this the same jar that is integrated to glassfish ?)
The sig tests currently pass in standalone mode, but fails in jsp & servlet vehicles, this needs to be investigated.

We will remove the javax.* and also update the jakarta.transaction.sig_1.2_se11 as jakarta.transaction.sig_2.0_se11 to be run in JDK11.

Regards,
Alwin

On 10/06/20 7:18 pm, Tom Jenkinson wrote:
Hi,

I am not very familiar with the requirements on signatures, but when I  look at https://www.eclipse.org/lists/jakartaee-spec-project-leads/msg00413.html and at https://github.com/eclipse-ee4j/jakartaee-tck/tree/master/src/com/sun/ts/tests/signaturetest/signature-repository, for Jakarta Transactions I am thinking:

1. We need to add a jakarta.transaction.sig_2.0_se11 (I am not sure what would go in there though)
2. The following should be removed:
   * jakarta.transaction.sig_1.2_se11
   * javax.transaction.sig_1.2_se8
   * javax.transaction.sig_1.3_se8

Thanks for your assistance,
Tom

_______________________________________________
jakartaee-tck-dev mailing list
jakartaee-tck-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/jakartaee-tck-dev

Back to the top