| Re: [jakartaee-platform-dev] Staged EE 10 Platform TCK for running on Java 21 (as well as Java 11/17) which also updates Web tests that previously used (optional) web-app_2_2.dtd + addresses some Persistence challenges... |
My WildFly (`main` branch) testing of the staged Platform TCK on Java 21 saw zero Platform TCK failures on July 2 and therefore I think it is time to promote the mentioned EE 10 Platform TCKs. I'll create a pull request https://github.com/jakartaee/specifications pull request for that.
Scott
On Mon, Jul 1, 2024, 5:35 PM Scott Marlow <smarlow@xxxxxxxxxx> wrote:
On 7/1/24 2:46 PM, Scott Marlow wrote:
Looks like we missed a failure with the assembly tests in the [7] run:
"
Caused by: org.xml.sax.SAXParseException; lineNumber: 28; columnNumber: 18; Deployment descriptor file WEB-INF/web.xml in archive [assembly_compat_standalone_war_compat12_13_component_web]. cvc-complex-type.2.4.a: Invalid content was found starting with element '{"https://jakarta.ee/xml/ns/jakartaee":description}'. One of '{"https://jakarta.ee/xml/ns/jakartaee":servlet-class, "https://jakarta.ee/xml/ns/jakartaee":jsp-file, "https://jakarta.ee/xml/ns/jakartaee":init-param, "https://jakarta.ee/xml/ns/jakartaee":load-on-startup, "https://jakarta.ee/xml/ns/jakartaee":enabled, "https://jakarta.ee/xml/ns/jakartaee":async-supported, "https://jakarta.ee/xml/ns/jakartaee":run-as, "https://jakarta.ee/xml/ns/jakartaee":security-role-ref, "https://jakarta.ee/xml/ns/jakartaee":multipart-config}' is expected.
"Will need to address ^ and stage a new Platform TCK build.
Addressed via https://github.com/jakartaee/platform-tck/pull/1348 and tested via https://ci.eclipse.org/jakartaee-tck/job/jakartaee-tck-scottmarlow/job/assembly_10.0.x/4
After pull/1348 is approved and merged, we will need to rebuild/restage the [1] Platform TCK.
Pull/1348 was merged and we rebuilt and staged the Platform TCK.
https://ci.eclipse.org/jakartaee-tck/job/jakartaee-tck/job/10.0.x/136/ is running a test run with Java 17.
ScottScott
On 7/1/24 1:12 PM, Scott Marlow wrote:
A new EE 10 Platform TCK has been staged [1] that includes changes for various TCK challenges via [2] that can be summarized as covering additional Java 21 changes + updating from tests from web-app_2_2.dtd => web-app_5_0.xsd. A few Persistence TCK challenges have been addressed as well.
Component TCKs [3][4][5] have been staged to reflect Platform TCK test changes made for the EE 10 Platform TCK.
I started a GlassFish TCK run against [1] via the [7] CI job (testing with Java 17 as we haven't added Java 21 support yet to that job). I'm also testing WildFly against[1] on Java 21.
If other implementations would like to run against the [1] staged jakarta-jakartaeetck-10.0.5.zip, please respond to this email if you need more time to test any of the staged TCKs beyond the end of this week. I'd like to create a specifications repo pull request [8] to promote the TCKs some time next week.
Scott
[2] changes:
- https://github.com/jakartaee/platform-tck/issues/1313 accepted TCK challenge "Old DTDs/Schema in deployment descriptors of Tags/Pages/Servlet/Assembly Platform TCK tests"
- https://github.com/jakartaee/persistence/issues/637 accepted TCK challenge "TCK should not set version on entity manually"
- https://github.com/jakartaee/persistence/issues/632 accepted TCK challenge "Derived identity TCK tests rely on unspecified cascading behavior"
- https://github.com/jakartaee/platform-tck/issues/1260 accepted TCK challenge "SQL DML change for running on Java 21"
- https://github.com/jakartaee/platform-tck/pull/1321 - JspException.getRootCause() has been deprecated and was removed in Pages 4.0 (Jakarta EE11).
- https://github.com/jakartaee/tags/issues/255 accepted TCK challenge for running on Java 19+ "Update jstl dates for java21"
[3] https://www.eclipse.org/downloads/download.php?file=/ee4j/jakartaee-tck/jakartaee10/staged/eftl/jakarta-servlet-tck-6.0.2.zip
[7] https://ci.eclipse.org/jakartaee-tck/job/10/job/eftl-jakartaeetck-run-100/237/
[8] https://github.com/jakartaee/specifications