Skip to main content
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [jakartaee-platform-dev] JSTL Shaded Prefix
Sorry, I just re-read my statement and was missing a crucial NOT.  "In the end the package name should NOT be that important..."
 
Not that this changes Joakim's agreement with me!

Tom
 
 
 
----- Original message -----
From: "Joakim Erdfelt" <joakim.erdfelt@xxxxxxxxx>
Sent by: "jakartaee-platform-dev" <jakartaee-platform-dev-bounces@xxxxxxxxxxx>
To: "jakartaee-platform developer discussions" <jakartaee-platform-dev@xxxxxxxxxxx>
Cc:
Subject: [EXTERNAL] Re: [jakartaee-platform-dev] JSTL Shaded Prefix
Date: Thu, Jan 27, 2022 8:39 AM
 
I agree, it should be a package namespace that the implementation controls.
Don't invent new ones.
 
- Joakim
 
On Thu, Jan 27, 2022 at 8:14 AM Thomas Watson <tjwatson@xxxxxxxxxx> wrote:
My suggestion would be to use org.eclipse.jakarta.<spec>.shaded as the package name.  In the end the package name should be that important because it is all internal to the implementation, if I understand correctly.
 
I really hope this doesn't turn into another long discussion on package names...

Tom
 
 
 
----- Original message -----
From: "Paul Nicolucci" <pnicolucci@xxxxxxxxx>
Sent by: "jakartaee-platform-dev" <jakartaee-platform-dev-bounces@xxxxxxxxxxx>
To: "jakartaee-platform developer discussions" <jakartaee-platform-dev@xxxxxxxxxxx>
Cc:
Subject: [EXTERNAL] Re: [jakartaee-platform-dev] JSTL Shaded Prefix
Date: Wed, Jan 26, 2022 5:55 PM
 
Hi,
 
Do we want to use ee.jakarta.shaded.[spec] or the API groupid in the implementation code?
 
 
The implementation is under the following groupid:
 
     <groupId>org.glassfish.web</groupId>
     <artifactId>jakarta.servlet.jsp.jstl</artifactId>
     <version>3.0.0-SNAPSHOT</version>
     <packaging>jar</packaging>
 
The API is published as follows:
 
     <groupId>jakarta.servlet.jsp.jstl</groupId>
     <artifactId>jakarta.servlet.jsp.jstl-api</artifactId>
     <version>3.0.0-SNAPSHOT</version>
     <packaging>jar</packaging>
 
Perhaps base it off of the existing package naming which uses `taglibs`: https://github.com/eclipse-ee4j/jstl-api/tree/master/impl/src/main ?
 
 
 
Regards,
 
Paul Nicolucci
 
On Wed, Jan 26, 2022 at 3:35 PM BJ Hargrave <hargrave@xxxxxxxxxx> wrote:
How about ee.jakarta.shaded.servlet.jsp.jstl?
 
ee.jakarta.tck.[spec] is the recommended package prefix for TCK code. We could use ee.jakarta.shaded.[spec] as the package prefix for shaded packages. I suppose "servlet.jsp.jstl" as the spec name could be shortened to "jstl", but "jakarta.servlet.jsp.jstl" is the groupId for JSTL.
--

BJ Hargrave
Senior Technical Staff Member, IBM // office: +1 386 848 1781
OSGi Fellow and OSGi Specification Project lead // mobile: +1 386 848 3788
hargrave@xxxxxxxxxx
 
 
----- Original message -----
From: "Volodymyr Siedlecki" <volosied@xxxxxxxxx>
Sent by: "jakartaee-platform-dev" <jakartaee-platform-dev-bounces@xxxxxxxxxxx>
To: jakartaee-platform-dev@xxxxxxxxxxx
Cc:
Subject: [EXTERNAL] Re: [jakartaee-platform-dev] JSTL Shaded Prefix
Date: Wed, Jan 26, 2022 14:57
 
Hello,
 
To be clear, this shaded package is in the implementation, not the API.
 
A few other suggestions include:
  • org.eclipse.jstl.shaded
  • org.eclipse.tags.shaded (as we slowly move from the jstl name)
  • org.eclipse.jakarta.tags.shaded
 
Are there any preferences?
 
Thanks,
Volodymyr
JSTL Committer
 
 
 
 
On Mon, Jan 24, 2022 at 2:34 PM Volodymyr Siedlecki <volosied@xxxxxxxxx> wrote:
Hello,

In the jstl-api project, we updated the prefix of a shaded package from com.oracle.wls.shaded to org.eclipse.shaded.

Our question is if there are any issues with this new prefix or should we change it to something else, perhaps?

Here's our PR for reference: https://github.com/eclipse-ee4j/jstl-api/pull/181 


Thank you,
Volodymyr
JSTL Committer
_______________________________________________
jakartaee-platform-dev mailing list
jakartaee-platform-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/jakartaee-platform-dev
 


_______________________________________________
jakartaee-platform-dev mailing list
jakartaee-platform-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/jakartaee-platform-dev
_______________________________________________
jakartaee-platform-dev mailing list
jakartaee-platform-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/jakartaee-platform-dev
 


_______________________________________________
jakartaee-platform-dev mailing list
jakartaee-platform-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/jakartaee-platform-dev
_______________________________________________
jakartaee-platform-dev mailing list
jakartaee-platform-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/jakartaee-platform-dev
 


Back to the top