Re: [jakartaee-platform-dev] History of Mojarra dependency?

[Romain Grecourt <romain.grecourt@xxxxxxxxxx>]

    Like you said, this API jar has a compile dependency on
    com.sun.faces classes.
    The build unpacks all sources and attaches them to have the
    maven-compiler-plugin compile everything.
    
    I'm not sure how you got it to work without the dependency on
    Mojarra.
    
    If I comment out the dependency, I get compilation errors:
    
    diff --git a/jakartaee-web-api/pom.xml
      b/jakartaee-web-api/pom.xml
    index c2b11ea..187240a 100644
    --- a/jakartaee-web-api/pom.xml
    +++ b/jakartaee-web-api/pom.xml
    @@ -107,12 +107,12 @@
                 <optional>true</optional>
             </dependency>
             <!-- work around for GLASSFISH-19861  -->
    -        <dependency>
    +<!--        <dependency>
                 <groupId>org.glassfish</groupId>
                
      <artifactId>jakarta.faces</artifactId>
                
      <version>${mojarra.version}</version>
                 <optional>true</optional>
    -        </dependency>
    +        </dependency> -->
             <dependency>
                 <groupId>jakarta.faces</groupId>
                
      <artifactId>jakarta.faces-api</artifactId>
    
    [ERROR]
/Users/rgrecour/workspaces/jakartaee-api/jakartaee-web-api/target/sources-dependency/javax/faces/component/UIComponent.java:[19,33]
      package com.sun.faces.util does not exist
    [ERROR]
/Users/rgrecour/workspaces/jakartaee-api/jakartaee-web-api/target/sources-dependency/javax/faces/component/UIComponent.java:[19,1]
      static import only from classes and interfaces
    [ERROR]
/Users/rgrecour/workspaces/jakartaee-api/jakartaee-web-api/target/sources-dependency/javax/faces/component/UIComponent.java:[20,33]
      package com.sun.faces.util does not exist
    [ERROR]
/Users/rgrecour/workspaces/jakartaee-api/jakartaee-web-api/target/sources-dependency/javax/faces/component/UIComponent.java:[20,1]
      static import only from classes and interfaces
    
    On 3/4/20 2:54 PM, Kevin Sutter wrote:

Hi,
This question is probably targeted at Bill, but while I was looking to update the pom in jakartaee-api for a Jakarta EE 9 Milestone/RC API, I came across this dependency on Mojarra:

        <!-- work around for GLASSFISH-19861  -->
        <dependency>
            <groupId>org.glassfish</groupId>
            <artifactId>jakarta.faces</artifactId>
            <version>${mojarra.version}</version>
            <optional>true</optional>
        </dependency>

I know all about the JSF API being dependent on Mojarra, but we're already bringing in the JSF API as a separate dependency.  I looked up the Issue that is referencedand it was closed back in 2013...  It looks like there was a discussion between Ed and Bill about whether this dependency on com.sun.faces had to be removed or not...  The end result looks like leaving these references was an okay operation for Mojarra.

But, I'm confused as to what this is doing for the generation of the API jar files.  Whether I have this dependency in or out of the pom, it looks to still generate the API jar files (without the com.sun.faces classes).  Any ideas?

---------------------------------------------------
Kevin Sutter
STSM, MicroProfile and Jakarta EE architect @ IBM
e-mail:  sutter@xxxxxxxxxx     Twitter:  @kwsutter
phone: tl-553-3620 (office), 507-253-3620 (office)    
LinkedIn: https://www.linkedin.com/in/kevinwsutter

_______________________________________________
jakartaee-platform-dev mailing list
jakartaee-platform-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://urldefense.com/v3/__https://www.eclipse.org/mailman/listinfo/jakartaee-platform-dev__;!!GqivPVa7Brio!ODjV_T1Yb1t7oF2V5BmI-5E943iuf1qpCBfmd-GFh1KIgdmd8bM3CmLvUud-KdxyC7bl$