Skip to main content
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [jakartabatch-dev] The official way to run the TCK?
The reason I asked was that I was playing with the TCK and wanted to try adding Arquillian support and run it against Payara. First, I was thinking of porting the Ant based project to Maven, but soon enough, luckily, I discovered that this was already done but not yet documented.

So I have a look at the current state of the mavenized TCK and suggested some enhancements in the PR. The mavenized version is very similar to most of the MicroProfile TCKs so I felt like at home with it. I didn't realize it's not complete and the signature tests are not covered.

If you give me some pointers to teh Ant-based signature tests which are missing in the Mavenized TCK, I can have a look at how we can run those tests there. maybe it's anough to use Maven Ant runner plugin to run those tests without many changes.

Meanwhile, I managed to add support for Arquillian in my fork. With the latest version, I am able to run the SE tests with the JBatch impl and both SE and EE tests with Payara Server. But I'll write about that in the other thread about TCK. 

Kind regards,

Ondrej Mihályi

Senior Payara Service Engineer
Payara-Tech LDA - Open Source Enterprise Software & Support
E: ondrej.mihalyi@xxxxxxxxxxx | T: +1 415 523 0175 | M: +421 902 079 891

----------------------------------------------------------------------------------------------------------------------

Payara-Tech LDA, Registered Office: Rua Nova de São Pedro no. 54, 2nd floor, room “D”, 9000 048 Funchal, Ilha da Madeira, Portugal

VAT: PT 515158674 | www.payara.fish | info@xxxxxxxxxxx | @Payara_Fish

From: jakartabatch-dev-bounces@xxxxxxxxxxx <jakartabatch-dev-bounces@xxxxxxxxxxx> on behalf of Scott Kurz <skurz@xxxxxxxxxx>
Sent: 24 March 2020 22:55
To: jakartabatch-dev@xxxxxxxxxxx <jakartabatch-dev@xxxxxxxxxxx>
Cc: jakartabatch-dev@xxxxxxxxxxx <jakartabatch-dev@xxxxxxxxxxx>
Subject: Re: [jakartabatch-dev] The official way to run the TCK?
 
Hi Ondro,
 
Thanks for the suggestion and sorry we didn't already have more obvious pointers to what's what.   
 
If you go back far enough (~2013), the original standalone TCK used Ant and the Maven execution of the runtime (TestNG) tests was added later as an informal/unofficial convenience.
 
But we never built a Maven execution for the SigTest (signature) tests.  I remember at the time there was some annoying difference btw. IBM and Oracle JDK/JRE layout, but I'm sure there's no reason we couldn't address this, (and also update the doc and sample config).    So we left the Ant-based runtime execution (since we did it first), though I'm sure most people now will use the Maven approach.
 
with a bit more detail).
 
One more note:  because this is all so complicated we include sample config for running against the com.ibm.jbatch impl, being careful to distinguish these pieces from the rest of the TCK
 
So, if you still think your PR would be useful let me know and I can take a look.
 
Thanks,
------------------------------------------------------
Scott Kurz
WebSphere Batch and Developer Experience
skurz@xxxxxxxxxx
--------------------------------------------------------
 
 
----- Original message -----
From: "Ondro Mihályi" <ondrej.mihalyi@xxxxxxxxx>
Sent by: jakartabatch-dev-bounces@xxxxxxxxxxx
To: jakartabatch-dev@xxxxxxxxxxx
Cc:
Subject: [EXTERNAL] Re: [jakartabatch-dev] The official way to run the TCK?
Date: Sun, Mar 22, 2020 8:54 PM
 
As I played with the Maven exec project, I attempted to simplify it a bit. Here's my humble PR: https://github.com/eclipse-ee4j/batch-tck/pull/4
 
Ondro
 
po 23. 3. 2020 o 1:29 Ondro Mihályi <ondrej.mihalyi@xxxxxxxxx> napísal(a):
Hi,
 
As I explored the standalone TCK, I became confused with how to run the TCK suite with JBatch impl. The documentation suggests to use the how-to-run-tck-against-jbatch-script.sh in  the TCK distribution, which in turn uses and to run the suite.
 
However, there's also a maven project https://github.com/eclipse-ee4j/batch-tck/tree/master/com.ibm.jbatch.tck.exec which runs the suite in a much simpler way just using maven. The project just configures JBatch and runs the tests in the Core Test maven artifact with plain `mvn verify`.
 
According to the git history, the latter way using Maven is older and has existed since the initial CQ. The Ant way of running the tests is newer. But to me that looks like a step back, isn't it? Why would we want to use Ant if we have a native Maven way of running the TCK? Isn't it better to bundle the maven project JBatch TCK exec and change the instructions to use it instead of the Ant project?
 
Ondro
_______________________________________________
jakartabatch-dev mailing list
jakartabatch-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/jakartabatch-dev
 

Back to the top