Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [jakarta.ee-spec] [jakarta.ee-spec.committee] TCK Urls...

On Aug 5, 2020, at 3:20 PM, Kevin Sutter <sutter@xxxxxxxxxx> wrote:

I checked our promotion script (https://github.com/jakartaee/specification-tools/tree/master/promotion), and it looks like we take a fully qualified url (as long as it starts with https://download.eclipse.org).  So, maybe this is not a big deal...

Right, whatever the project wants to supply as their TCK URL works as long is they keep that URL stable throughout the vote.

They could supply a directory in the PR, but you know then one of us humans has to pick the right URL and since we aren't committers on the project we'd probably human it up eventually. "you picked the wrong URL! / you read my mind incorrectly! / I was vague and got what I deserved! "


-David

From:        "Kevin Sutter" <sutter@xxxxxxxxxx>
To:        Jakarta specification committee <jakarta.ee-spec.committee@xxxxxxxxxxx>
Cc:        Jakarta specification discussions <jakarta.ee-spec@xxxxxxxxxxx>
Date:        08/05/2020 16:51
Subject:        [EXTERNAL] Re: [jakarta.ee-spec] [jakarta.ee-spec.committee] TCK Urls...
Sent by:        jakarta.ee-spec-bounces@xxxxxxxxxxx




David,
Sorry, I just used the directories because I didn't want to get hung up on the names...  (jakarta vs eclipse vs blank, etc)


When we run the promotion script for the TCK, do we provide a complete url pointing at the file?  Or, is it being expected in a certain location and we only provide the file name?  If it's the former, then I agree with you that it doesn't matter much where it's staged -- just so that it doesn't change.  In the past, we used the "promoted" directory structure.  I'm just trying to figure out if we have something to check on during our mentoring reviews.  Thanks.

---------------------------------------------------
Kevin Sutter
STSM, MicroProfile and Jakarta EE architect @ IBM
e-mail:  sutter@xxxxxxxxxx     Twitter:  @kwsutter
phone: tl-553-3620 (office), 507-253-3620 (office)    
LinkedIn:
https://www.linkedin.com/in/kevinwsutter



From:        
David Blevins <dblevins@xxxxxxxxxxxxx>
To:        
Jakarta specification committee <jakarta.ee-spec.committee@xxxxxxxxxxx>
Date:        
08/05/2020 15:08
Subject:        
[EXTERNAL] Re: [jakarta.ee-spec.committee] TCK Urls...
Sent by:        
jakarta.ee-spec.committee-bounces@xxxxxxxxxxx




On Aug 5, 2020, at 12:26 PM, Kevin Sutter <
sutter@xxxxxxxxxx> wrote:

Hi,
I'm finding several inconsistencies with the TCK references in the Specification PRs, especially with the directory structures and expected locations.

In the _index.md file for the TCK location, we should be specifying this directory structure:

https://download.eclipse.org/jakartaee/{spec}/x.y/jakarta-{spec}-tck-x.y.z.zip  (this is in our checklist, so I think we're good with this)

But, where should the "staged" version of the TCK be located?  We have an item in the PR checklist to identify the staged location.  I have seen the following directory structures being referenced...


https://download.eclipse.org/ee4j/cdi/inject/2.0/(as an example)
https://download.eclipse.org/ee4j/jakartaee-tck/jakartaee9-eftl/staged-900/
https://download.eclipse.org/ee4j/jakartaee-tck/jakartaee9-eftl/promoted/

With Jakarta EE 8, it looks like we expected the TCKs to be staged in the "promoted"directory (per a quick sampling of the past PRs - except for cdi and bv...).  How the TCKs get to the "staged-900" and "promoted" directories is a mystery to me.  We started to discuss it on this morning's call.  Maybe we can continue this conversation here instead of waiting for next week's call...


Personally, I just want a complete link that includes the zip file.  As long as the file on the other side of the link is not getting overwritten and stable enough to last a complete PR cycle, I don't care where the project decided to put it.

I'm not a fan of having a directory put in front of me.  I could guess the wrong file, I could accidentally promote the wrong file.  I can't write code to further improve the promotion script so we could perhaps just point at the PR and have it pull out everything that needs promoting.  Then there's miscommunication opportunities: "Well of course that zip file has been overwritten, everyone on our project knows that directory is for nightly builds"

In short, we don't promote directories we promote a zip file.  Give me a zip file and I'm happy.  Give me a directory and now we have to have discussions I'd prefer to avoid.

That's my $0.02 at least.


-David

_______________________________________________
jakarta.ee-spec.committee mailing list
jakarta.ee-spec.committee@xxxxxxxxxxx
To unsubscribe from this list, visit
https://www.eclipse.org/mailman/listinfo/jakarta.ee-spec.committee


_______________________________________________
jakarta.ee-spec mailing list
jakarta.ee-spec@xxxxxxxxxxx
To unsubscribe from this list, visit
https://www.eclipse.org/mailman/listinfo/jakarta.ee-spec



_______________________________________________
jakarta.ee-spec mailing list
jakarta.ee-spec@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/jakarta.ee-spec


Back to the top