Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [jakarta.ee-spec] Automation for creating boilerplate-spec PRs

I suspect it was due to the Jakarta Transactions API pom not being quite the same structure as the JMS so I created the new parent pom by hand to workaround it.

Thanks for producing the tool David!

On Thu, 11 Jul 2019 at 17:22, Tom Jenkinson <tom.jenkinson@xxxxxxxxxx> wrote:
Running it in the IDE gets me a bit further but the pom.xml it is generating at the top level is basically the content of the template - I am still investigating...

On Thu, 11 Jul 2019 at 16:41, Tom Jenkinson <tom.jenkinson@xxxxxxxxxx> wrote:
That looks really useful! Please can you let me know how to run it for the other projects? I have git cloned it and mvn clean installed it but it is failing to download tomitribe-utils:1.3.2-SNAPSHOT - I tried it with 1.3.1 of that dep but got an error so I did:
git clone git@xxxxxxxxxx:tomitribe/tomitribe-util.git
// git -1 gets me 224eec8652de0d9ed64b3948e03c0580b10719b0
cd tomitribe-util
mvn clean install

That allowed me to mvn clean install -DskipTests (one of the tests failed due to some IO thing I think)

I next edited https://github.com/jakartaee/specification-tools/blob/master/boilerplate-specs/src/main/java/org/eclipse/jakartaee/tools/bps/AddBoilerplateSpec.java to specify jta-api and then "cd target; java org.eclipse.jakartaee.tools.bps.AddBoilerplateSpec"

- would I be on the right route - I am getting some GITHUB_TOKEN required - what permissions should that have?

On Thu, 11 Jul 2019 at 15:28, David Blevins <dblevins@xxxxxxxxxxxxx> wrote:
End-to-end success achieved on jms-api:

 - https://github.com/eclipse-ee4j/jms-api/pull/225

Generator source is here:


Tried ejb-api and management-api.  Notice some differences that threw the generator off.  Didn't look serious.  Pulled an all-nighter so going to get a few hours of sleep then try on some other projects.

-- 
David Blevins
310-633-3852

_______________________________________________
jakarta.ee-spec mailing list
jakarta.ee-spec@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://www.eclipse.org/mailman/listinfo/jakarta.ee-spec

Back to the top