| Re: [jakarta.ee-spec.committee] TCK zip file name |
In the review checklist, the TCK download pattern is:
Link to final TCK download zip file of the form https://download.eclipse.org/jakartaee/{spec}/x.y/*{spec}-tck-x.y.z.zipHere is the current variance for the ballot-ready TCKs
http://download.eclipse.org/jakartaee/cdi/3.0/cdi-tck-3.0.0-dist.zip
https://download.eclipse.org/jakartaee/batch/2.0/jakarta.batch.official.tck-2.0.0.zip
https://download.eclipse.org/jakartaee/platform/9/jakarta-jakartaeetck-9.0.0.zip (Interceptors)
https://download.eclipse.org/jakartaee/bean-validation/3.0/beanvalidation-tck-dist-3.0.0.zip
https://download.eclipse.org/jakartaee/dependency-injection/2.0/jakarta.inject-tck-2.0.1-bin.zip
To summarize, the file-name differences: CDI adds the suffix -dist; Batch inserts 'official' and uses periods instead of hyphens; Interceptors follows the pattern. BV adds -dist, DI adds -bin to the end.
I don't think
this situation is appreciably different from Jakarta
EE 8. I would recommend that the Spec. committee vote
to relax the requirements of the final checklist. My
detailed recommendation is: I think the folder paths
must be followed:
The final file
name can be some reasonable form of:
(A simple parenthetical could be added: folder path required, file-name preferred, but not required)
OR, we can follow the prescription currently in the checklist --
request the changes in the _index.md files and ensure any name
discrepancies are fixed when the committee member pushes the final
copies to the jakartaee download folders.
I agree with Ed. We have defined what the tck name should look like to make it easier for the reviewer. But, at the end of the day, the real name is determined by the promotion script that is run by a member of the Spec Committee. In most cases, the various TCKs were named using the defined convention -- exceptions were CDI, BV, and Batch. I think most of the others followed the convention.
---------------------------------------------------
Kevin Sutter
STSM, MicroProfile and Jakarta EE architect @ IBM
e-mail: sutter@xxxxxxxxxx Twitter: @kwsutter
phone: tl-553-3620 (office), 507-253-3620 (office)
LinkedIn: https://www.linkedin.com/in/kevinwsutter
From: Ed Bratt <ed.bratt@xxxxxxxxxx>
To: Jakarta specification committee <jakarta.ee-spec.committee@xxxxxxxxxxx>, "kzr@xxxxxxxxxxx" <kzr@xxxxxxxxxxx>
Date: 08/10/2020 17:52
Subject: [EXTERNAL] Re: [jakarta.ee-spec.committee] TCK zip file name
Sent by: jakarta.ee-spec.committee-bounces@xxxxxxxxxxx
Good catch!
My input:
Each group can decide what it wants its staged files to be named. Once they are moved to the normative location, the committee can decide.
In Jakarta EE 8, I do not think we were particularly dogmatic about the final file names. I think we used whatever the stage name was.
For DI(I mentored), I just checked that the staged zip file existed and the SHA matched the sum from the CCR. In dependency-injection/2.0/_index.md, I left the target URL alone and gave the PR a "pass" with the file-name that matches the stage file name.
If we want the final names to match exactly, I would need to request this change from DI (though this would only change the name of the final download, I think). Based on what you wrote, it seems other TCK zip files would have to be renamed also.
For TCKs in Jakarta EE TCK I think their zip-file names already conform with the guidelines but that isn't all TCKs.
Either way works for me. I confess, I didn't strictly follow the guidelines in the longer "Spec. Review Checklist." I think it's easier to use the name from the project's stage location. I realize that isn't quite consistent across the board for the Specifications.
-- Ed
On 8/10/2020 3:24 PM, kzr@xxxxxxxxxxxwrote:
Let me make sure the form of the *final* TCK zip name.
According to the checklist, the form should be:
https://download.eclipse.org/jakartaee/{spec}/x.y/*{spec}-tck-x.y.z.zip
But some of the current PRs do not exactly conform to this form.
I am not clear how strictly we should apply this rule.
- Servlet
https://download.eclipse.org/jakartaee/servlet/5.0/jakarta-servlet-tck-5.0.0.zip
It seems to be OK.
- Bean Validation
http://download.eclipse.org/ee4j/bean-validation/3.0/beanvalidation-tck-dist-3.0.0.zip
“dist” is inserted between “{spec}-tck-” and “x.y.z.zip”.
Is it OK?
- Batch
https://download.eclipse.org/jakartaee/batch/2.0/jakarta.batch.official.tck-2.0.0.zip
“official” is inserted between “{spec}-” and “tck-x.y.z.zip”.
Is it OK?
-Kenji Kazumura
_______________________________________________
jakarta.ee-spec.committee mailing list
jakarta.ee-spec.committee@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/jakarta.ee-spec.committee
_______________________________________________
jakarta.ee-spec.committee mailing list
jakarta.ee-spec.committee@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/jakarta.ee-spec.committee
_______________________________________________ jakarta.ee-spec.committee mailing list jakarta.ee-spec.committee@xxxxxxxxxxx To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/jakarta.ee-spec.committee