| Re: [jakarta.ee-spec.committee] Mentoring specifications |
Ed,
That's why I mentioned it was just a "reminder" and not a firm requirement. Of course, if each component does this step of creating an API PR, then we know it's done and ready for inclusion. Otherwise, it's just more work on the API team (me, in this case) to do the verification. Thanks!
---------------------------------------------------
Kevin Sutter
STSM, MicroProfile and Jakarta EE architect @ IBM
e-mail: sutter@xxxxxxxxxx Twitter: @kwsutter
phone: tl-553-3620 (office), 507-253-3620 (office)
LinkedIn: https://www.linkedin.com/in/kevinwsutter
From: Ed Bratt <ed.bratt@xxxxxxxxxx>
To: Kevin Sutter <sutter@xxxxxxxxxx>, Jakarta specification committee <jakarta.ee-spec.committee@xxxxxxxxxxx>
Date: 07/20/2020 09:45
Subject: [EXTERNAL] Re: [jakarta.ee-spec.committee] Mentoring specifications
My quick scan of existing PRs didn't suggest there was a one-for-one relationship between PRs and each specification. Of course, multiple specs can refer to a single PR.
Asking the committer team for confirmation this has been done is fine with me, if that's the consensus. Personally, looking at each PR in jakartaee-api, could be tedious (though, certainly it could be educational!).
Thinking about this a bit more -- possibly this is really an issue for the Platform API and not necessarily a requirement for each component specification. It isn't clear to me, how this is a requirement for a component specification to go to ballot. I suppose we could decide that adoption in the jakartaee-api project -- for those specifications included there -- must perform this step as a quality test (or something along those lines).
-- Ed
On 7/20/2020 7:27 AM, Kevin Sutter wrote:
Thanks for this reminder checklist, Ivar.
Yes, item #10 about submitting a PR for updating the jakartaee-api pom is a reminder. Each mentor should tell the component of this requirement. In most cases, that will be sufficient. For Jakarta EE 8, many components put a link to the actual PR either in the checklist (if they have access) or as a comment in the Spec PR. Thanks.
---------------------------------------------------
Kevin Sutter
STSM, MicroProfile and Jakarta EE architect @ IBM
e-mail: sutter@xxxxxxxxxx Twitter: @kwsutter
phone: tl-553-3620 (office), 507-253-3620 (office)
LinkedIn: https://www.linkedin.com/in/kevinwsutter
From: Ivar Grimstad <ivar.grimstad@xxxxxxxxxxxxxxxxxxxxxx>
To: Ed Bratt <ed.bratt@xxxxxxxxxx>
Cc: Jakarta specification committee <jakarta.ee-spec.committee@xxxxxxxxxxx>
Date: 07/20/2020 09:11
Subject: [EXTERNAL] Re: [jakarta.ee-spec.committee] Mentoring specifications
Sent by: jakarta.ee-spec.committee-bounces@xxxxxxxxxxx
Thanks, Ed
I wrote it down to help myself, and realized it could help others as well :)
Regarding your comment about item #10 in the checklist, I guess asking them to confirm should be enough.
Ivar
On Sat, Jul 18, 2020 at 10:05 PM Ed Bratt <ed.bratt@xxxxxxxxxx> wrote:
Ivar,
Thank you for this summary and suggested list of outreach steps. This is super helpful.
The very last item in the checklist (#10) seems a bit challenging to verify. I requested the DI team to simply confirm this change has happened. Otherwise, we will need to read the master POM. Should we do that as part of our review?
-- Ed
On 7/18/2020 7:07 AM, Ivar Grimstad wrote:
Esteemed specification committee members,
The ballots for the first wave of specifications are scheduled to start on Monday 20th. You are probably all well underway reviewing the PRs for specifications to which you were assigned as a mentor. I have compiled a short checklist for what needs to be done.
If a PR has been created for the specificationIf a PR has NOT yet been created for the specification
- Assign yourself as a reviewer
- Add a comment to the PR containing the checklist [1], like Kevin has done for [2]
- Start reviewing
- [optional] Join the mailing list for the project producing the specification
- [optional] It may be a nice gesture to send an email to the project mailing list explaining what you are doing. An example here [5]
[1] https://github.com/jakartaee/specification-committee/blob/master/spec_review_checklist.md
- Check which wave it is in [3]
- Check when the due date for the ballot start for that wave [4]
- Join the mailing list for the project producing the specification
- Send an email explaining your role as a mentor and ask if they are on track to make the due date for producing the PR
- Follow up until a PR has been created, then start reviewing
[2] https://github.com/jakartaee/specifications/pull/225
[3] https://eclipse-ee4j.github.io/jakartaee-platform/jakartaee9/JakartaEE9ReleasePlan
[4] https://eclipse-ee4j.github.io/jakartaee-platform/jakartaee9/JakartaEE9#jakarta-ee-9-schedule
[5] https://www.eclipse.org/lists/jaxws-dev/msg00031.html
Hope this helps.
Ivar
--Ivar Grimstad
Jakarta EE Developer Advocate | Eclipse Foundation, Inc.
Community. Code. Collaboration.
Join us at our virtual event: EclipseCon 2020- October 20-22
_______________________________________________
jakarta.ee-spec.committee mailing list
jakarta.ee-spec.committee@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/jakarta.ee-spec.committee
--Ivar Grimstad
Jakarta EE Developer Advocate | Eclipse Foundation, Inc.
Community. Code. Collaboration.
Join us at our virtual event: EclipseCon 2020- October 20-22_______________________________________________
jakarta.ee-spec.committee mailing list
jakarta.ee-spec.committee@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/jakarta.ee-spec.committee
_______________________________________________
jakarta.ee-spec.committee mailing list
jakarta.ee-spec.committee@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/jakarta.ee-spec.committee