Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [jakarta.ee-spec.committee] PR to fix WebSocket TCK link

Ed,
The process should be finding a reviewer or two, and once you have the approvals, go ahead with the merge.  Since we don't know how busy everyone is, I tend to pick several potential reviewers.  The first ones to take a look win!  :-)

I just reviewed your PR.  I think two the URL updates should be using https instead of http.  Once that is fixed up, I think it's ready to go.

---------------------------------------------------
Kevin Sutter
STSM, MicroProfile and Jakarta EE architect
e-mail:  sutter@xxxxxxxxxx     Twitter:  @kwsutter
phone: tl-553-3620 (office), 507-253-3620 (office)    
LinkedIn:
https://www.linkedin.com/in/kevinwsutter



From:        Ed Bratt <ed.bratt@xxxxxxxxxx>
To:        Jakarta specification committee <jakarta.ee-spec.committee@xxxxxxxxxxx>
Date:        12/02/2019 10:57
Subject:        [EXTERNAL] [jakarta.ee-spec.committee] PR to fix WebSocket TCK link
Sent by:        jakarta.ee-spec.committee-bounces@xxxxxxxxxxx




Hi,
Last week, I submitted a PR to fix the download link to the WebSocket TCK. This seems pretty straight forward, but I don't recall the process for nudging this over the "merge" line.
Could someone remind me what needs to be done, to get this merged?
As it is now, the link to the WebSocket TCK is broken at https://jakarta.ee/specifications/websocket/1.1/(also, the .sig and .sha are broken ... the PR fixes all of this for WebSocket).
(This is not to be confused with my separate inquiry regarding the misnamed TCKs for Eclipse Concurrency TCK -- which was fixed by Scott, Thank you Scott, and David for the follow-up with that.)
-- Ed
_______________________________________________
jakarta.ee-spec.committee mailing list
jakarta.ee-spec.committee@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://www.eclipse.org/mailman/listinfo/jakarta.ee-spec.committee




Back to the top