[
Date Prev][
Date Next][
Thread Prev][
Thread Next][
Date Index][
Thread Index]
[
List Home]
Re: [jakarta.ee-spec.committee] bug fixes in Jakarta EE 8 TCK Servlet tests
|
> On Aug 5, 2019, at 12:17 PM, Bill Shannon <bill.shannon@xxxxxxxxxx> wrote:
>
> I'd like to get some quick feedback on this issue to make sure we're
> not doing the wrong thing...
>
> A few bug fixes have been applied to the Servlet TCK for Jakarta EE 8.
> In my opinion, all the bugs are legitimate bugs in the TCK.
>
> Unfortunately, one of the fixes was not quite perfect and caused problems.
> Discussion here:
> https://www.eclipse.org/lists/jakartaee-tck-dev/msg00202.html
>
> Based on the principle that the Jakarta EE 8 TCK should be the same as
> the Java EE 8 TCK, we're proposing to back out *all* of these fixes to
> Servlet tests, both the one that caused problems and the ones that did
> not.
>
> Does anyone disagree with that approach?
Agree with the approach given the time constraints.
Regarding Tomcat's ability to pass the Servlet TCK, would those tests be excluded?
> Something to think about for the future...
>
> If these bugs were reported against the Java EE 8 TCK, we would likely
> provide alternate tests with the fixes. We decided not to allow alternate
> tests for Jakarta EE, so we would need to decide if or how to address these
> bugs in the future, before Jakarta EE 9. Would we simply exclude these
> buggy tests? Or would we allow these bugs to be fixed in a service release
> of the TCK?
>
> No answer required now.
My opinion on that one is pretty well established :)
If 100% of us agree we want the fixed tests and are ok with what that means with regards to our own passing of the TCK, then I don't see a reason why we wouldn't fix it in a service/patch release.
-David