[
Date Prev][
Date Next][
Thread Prev][
Thread Next][
Date Index][
Thread Index]
[
List Home]
Re: [jakarta.ee-community] [EXTERNAL] Re: [jakartaee-ambassadors] GlassFish Docker Support in Jakarta Starter
|
- From: Reza Rahman <reza_rahman@xxxxxxxx>
- Date: Sun, 23 Mar 2025 14:18:35 -0400
- Delivered-to: jakarta.ee-community@xxxxxxxxxxx
- List-archive: <https://www.eclipse.org/mailman/private/jakarta.ee-community/>
- List-help: <mailto:jakarta.ee-community-request@eclipse.org?subject=help>
- List-subscribe: <https://www.eclipse.org/mailman/listinfo/jakarta.ee-community>, <mailto:jakarta.ee-community-request@eclipse.org?subject=subscribe>
- List-unsubscribe: <https://www.eclipse.org/mailman/options/jakarta.ee-community>, <mailto:jakarta.ee-community-request@eclipse.org?subject=unsubscribe>
- Thread-topic: Re: [EXTERNAL] Re: [jakarta.ee-community] [jakartaee-ambassadors] GlassFish Docker Support in Jakarta Starter
- Ui-outboundreport: notjunk:1;M01:P0:bNXEyN/3SwM=;OWXA6fKmqT87LJq0SIErO4KkmVd FVV9zbvs+Zv507xL9vi+FIkQou726r73B/61DAtGjcoSdrUc+8JBq3TCqRpTgCoIJ3ofb08jJ FynEmMc2/cXCJIUV2BXBAVTrHZjOPhMSh9AICFSKbBJdw+bga2/y84rle9jBew3zn+AMi4z2S X0bpk4CjDEjzyiJqczx86NaGogy+PrbEKCWvKY//5P9MrppkEcOubGUMwECktF28dunhdEKn1 K4iVT2IGE+o2cK0JQiY5nrCaD6Nt895kIPaA2OugtmYn0vsZNCd2EUlCfomyzsgsaC9z1vLGy 8sg3cOBBCG47EXh9pPYdV83yYL/1wGBfws6P0iRVBV699MHYxH8qbW6F+vfdb5vIybu879U7P IGcA2JEncKPEOc1e3oiRtxEa7bD3TeHSDUiSv163ZBlxeGFDHaFULUfW2seIDX6hfGHKYJCem Iuv+8RzTsfRgiATcDYjabuc4ipzi0Ax+6Q5yYfpG+eIuk+Y5az2TRsYYvpyUBPzFSAetD6evF IM6EtOTKOK29DtreqbA8aeGM3M7qVojD5XGQzI/RX7QBA9t5jS/oUnjZ5Hrh7r/QIpE6rGthU StxRHID9MWQEIlzt8pINd3V0kSdO6zgcedgDclLYXntfiePLBgaq3k7qIAhb9muoXKSth5YQb 8AgJh6rfqLjcjuyKvK2yG0tTakaCkYfgbt2bybcxEIBQCNxos/q/o2ysqNj+9RGPykNoygJJN i+HYlw8egbj6GHnwts2OJ9RyuUE+FyH5vogIJopsfeLuvn+at6Tl8s6Ux3YjkmOEecFgWa/uS C+uLs3h5HW+xd52TJZigZPFVs3xtJxw88JrH3AutP+g0VRXYkgoO9AoZKgYf1b8TT3PSKymjC NbNujaaelciF3AKaFU+4tdkmR52VkH7P0YNyaYYtjAxR8MbEFWOVIyyfsVjv7LykQcoeZiOQH yzljBVWSeGT4TA06Q2d7W8DMXi4JVOp75MEwrXrrZwDLLKhOVlJWcWLmKiwjEb4KirkF2oFNw hB3FvIueLAPMDW3a315zCMDIpbQimPHadZjznFXVSGPwrlm0Fl19Z1qBPi1qZX2i21WWpkCW6 gmTtdjF//H1zWvUcGHEcvAeoWjKsu5xFqN6AIzU7h1rDXhDt7nTMqARbMpdzT83AD/2tcH7ZB nOZVSMwKvVEAWU91pHZmkRb3YrQLTwZStDUvYOQxCH7idPW6XSpk5Uytr1KfWj63JCHTmLeIu VdDeuaUGFa9AUGSDYzm7xYgacFuagsklnBc86B/ORbJ9FjtLdxA9XffHWeQOLVa+eBEhy9ez2 Igioa+G0tuXe+tSqGSRNaLd7ATgrT/6+f6AN6p5UQZgSIIr1VFaCdwp8LHMuMZpR46wrkmfwR n07c+mhhH0HZdzKPdfKVIqetM+gXXzmDFVXu1KUNrWF35aeP7vYsVhiuRugFC44Wzg2m5Jqdg h3BzNzEfWi7TZ78vMXoDNvUrc3GU=
The Jakarta EE Steering and Marketing Committees have been pretty clear that the Starter needs to help promote EE 11 as soon as possible as technically EE 11 Core (and soon Web) are now released. I think that’s a fair and reasonable request for a key part of the jakarta.ee website. It’s pretty easy for users to select whatever they want. The initial defaults are merely a starting point. Also, it appears users are actually choosing EE 11 already, including explicitly selecting Liberty. So there’s indication that we are actually helping promote the EE 11 Core Profile release already, exactly as intended and requested by working group stakeholders. Moreover, the Marketing Committee has expressed their appreciation of our current efforts towards EE 11 promotion.
The UI does not attempt to guess what the user wants. It only has an initial set of defaults and enables/disables options based on user input. I’ve now clarified the UI instructions to that effect. It’ll go out in the next release so hopefully should help.
Trying to guess what the user wants approaches the cyclomatic complexity of warranting AI. I think the validation enforcement code is already complex enough.
That said, as I said before I’ll still try to see if things can be improved on the JSF/PrimeFaces side. For example, it may be possible to bring attention to options that become invalid after a given selection (so maybe placing a red X after a radio button set).
From: Ondro Mihályi <mihalyi@xxxxxxxxxxx>
Sent: Sunday, March 23, 2025 1:48 PM
To: Reza Rahman <reza_rahman@xxxxxxxx>
Cc: starter developer discussions <starter-dev@xxxxxxxxxxx>; Jakarta EE Ambassadors <jakartaee-ambassadors@xxxxxxxxxxxxxxxx>; Jakarta EE community discussions <jakarta.ee-community@xxxxxxxxxxx>
Subject: Re: [EXTERNAL] Re: [jakarta.ee-community] [jakartaee-ambassadors] GlassFish Docker Support in Jakarta Starter
Sure, no problem on my side. It's OK that the GlassFish Docker option is enabled only for the full Platform because it's more correct. The Docker image contains only the full GlassFish distribution and it's not possible to run in a "profile" that allows only Web Profile functionality. The UI bug is acceptable too, I know there are sometimes issues like that in JSF. I thought it's a mistake in the validation rules, that's why I reported it.
I have just one more note as a feedback. I think that the decision to select Jakarta EE 11 is misleading at the current time, as it only supports Core Profile now. Most of the people care only about Platform or Web Profile, Core profile is really meant mostly for certifications of small runtimes, mainly MicroProfile-only runtimes. Most people, who want to use the Starter to generate a project, would immediately select Jakarta EE 10 or older, and then would also need to select Platform, because the Core profile is pre-selected.
Do you think it would make sense to switch to Full Profile if people select Jakarta EE 10 or older right after the page loads? I mean, if they didn't select Core or Web Profile themself but Core Profile was pre-selected because of the default Jakarta EE 11 option? Can I create a PR to do something like that?
Ondro
I'll look at the UI validation tomorrow.
For the Archetype, I simply accepted your PR. If you want to change something about that, please simply make another PR.
Obviously, please ensure whatever is supposed to be supported aligns with what the GlassFish project wants to do with Docker and profiles for users. That is what we try to ensure with other vendors like IBM for Liberty. Liberty does not have different images for different profiles as that is handled by the server.xml instead. Other vendors like Payara have different images for different profiles. I have no way to know what GlassFish wants to do with its Docker images but would want to ensure nothing is potentially misleading or inappropriate. I do know GlassFish has different binary distributions for the platform and web profile. I think that avoids the situation of users wanting the web profile but accidentally using features that are not actually in the web profile.
Great news, Reza!
Now that I look at it, I see that some runtimes, e.g. OpenLiberty, use the same Docker image for Platform and both profiles. GlassFish Docker support is restricted only to Platform. I think we can change this in the archetype and UI to also support profiles with the GlassFish Full Docker image, right?
And I think I found a glitch in the UI - if I select GlassFish Docker, then change Java version to some other than 17 (GlassFish only supports Java 17 with the stock Docker image), then Docker support is unselected but the No option is not selected. What's worse, when I select Java 17 again, it should be possible to select the Docker option but it's not clickable. I attach a video recording.
Ondro