-------- Original message --------
Date: 6/19/18 4:12 PM (GMT-05:00)
Subject: [jakarta.ee-community] @DataSourceDefinition
Hi,
As suggested by Reza, a continuation of
https://twitter.com/fe_amoraes/status/1004184072795586560
There's a couple of things that were being discussed
there, but configurability of the annotation was the
prime concern.
Mark Struberg additionally remarked several aspects
where underspecified.
It was mentioned that Payara and JBoss/WildFly
already support placeholders inside
the @DataSourceDefinition annotation and XML variant.
Liberty doesn't support that yet, but appeared to be
interested.
Together with a concept of "stage", to select between
known in-archive config sets, the ability to provide an
external config set, additionally password-aliasing, and
finally the ability to replace a data source fully via
server mechanisms (admin console, etc) it's possible to
setup a quite comprehensive and workable system.
However, none of that is standardised yet.
Specifically the fact that @DataSourceDefinition does
not distinguish between properties intended for the pool
and and properties intended for the data source itself,
can be troublesome.
Maybe it would be an idea if @DataSourceDefinition
(or a modern replacement thereof) moved to the JPA spec,
to that a more consistent trio of connection pool, data
source and persistence unit can be easily defined.
Kind regards,
Arjan Tijms
