Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
[imagen-dev] Looking over open pull requests

A pleasant surprise returning to this project is a number of open pull-requests:

Fix black grid line artifacts on nearest-neighbor interpolation
This looks good to me, and I can see a similar change made in the JAI-Ext codebase.

Fix artifacts on bicubic interpolation
The JAI-Ext codebase has diverged here, so while the fix appears to make sense (correcting a simple mistake), I believe the JAI-Ext codebase was considerably rewritten to respect NO_DATA during interpolation and may.
In this case I wish we had a visual or a test case to show something actually being addressed.

Maximum value of ushort is 65535, not 65536
The fix agrees with the GeoTIFF specification; and seems to be a "simple mistake" being corrected. 

Do not dispose Graphics2D field in finalizer
Finalizers are lots of trouble to debug, while the assessment and fix makes sense we should keep an eye out for any change to memory profile.

I would like to see these merged ahead of factoring the codebase into modules.
- -
Jody Garnett

Back to the top