Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [ide-dev] concrete action item - menu contribution

Well, sorry but it looked like we are not totally wiped.... :(
With the patch applied, I installed EMF Compare (take the EMF Compare + EMF Compare EGit), and when I have nothing in the EGerrit dashboard (no reviews showing) I still get an undesirable entry. Once I have something selected then it goes away.

Even though there was a bug in the EGerrit code, I still find the menu contribution mechanism to be a little too eager to add contributions to menus. To recap, the view where the problem happens was not participating in the active selection mechanism, did not contain an IProject (or other Resources) but simply our own domain object (EObject to be pedantic), and was not contributing to IAdaptable or any of those things. Basically it tries to be alone in its own little corner, and yet somehow contributions are made to it.

In this case I would not have expected that, and I think the same could be said of other people writing simple plugins.

Don't you think?

On 9/16/2016 12:09 PM, Lars Vogel wrote:
On Fri, Sep 16, 2016 at 5:49 PM, Matthias Sohn <matthias.sohn@xxxxxxxxx> wrote:
On Wed, Sep 14, 2016 at 5:32 PM, Pascal Rapicault <pascal@xxxxxxxxxxxx>
kudos to Thomas Wolf who contributed a patch to EGerrit fixing this issue
+1 Thanks Thomas for fixing EGerrit. No more SHITTING :-)
ide-dev mailing list
To change your delivery options, retrieve your password, or unsubscribe from this list, visit

Back to the top