Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [higgins-dev] Proposed changes to IContextFactory

This looks good to me.
 
Jim

>>> "Markus Sabadello" <msabadello@xxxxxxxxxxxxx> 7/25/07 2:57 PM >>>
Hello,

In accordance with ContextRefs being replaced by ContextIds (see http://wiki.eclipse.org/ContextId and http://wiki.eclipse.org/ContextDiscoveryComponents), I propose we make the following changes to the IContextFactory interface:

CHANGE:    public IContext createContext(URI contextRef) throws IdASException;
TO:   public IContext createContext(IContextId contextId) throws IdASException;

REMOVE:     public boolean canCreate(URI contextRef) throws IdASException;

We don't need canCreate() anymore (I think), since IdASRegistry will now do the job of finding an appropriate IContextFactory for a given IContextId.

Jim? Do you think that's smart?

As discussed on the last Higgins call, I am adding the following convenience methods to IdASRegistry:

    public IContext createContext(String contextIdStr) throws IdASException;
    public IContext createContext(IContextId contextId) throws IdASException;

Thanks for all the +1 votes! Looking forward to being a committer soon.

Markus


Back to the top