Re: [handly-dev] a few wonderings

[Vladimir Piskarev <pisv@xxxxx>]

Hi Vlad,

> * SourceConstruct should implement even hashCode to match equals. 
 
We just follow JDT lead here (see SourceRefElement).

See also https://dev.eclipse.org/mhonarc/lists/handly-dev/msg00056.html :-)

> * Why is the class called SourceElementBody and the interface ISourceElementInfo? Wouldn't it be better to keep using a single concept? I'd have preferred to have "body" everywhere, but I can see a point in a different name, as it's not quite the same kind of data as for a source file or project.

I think I'd prefer to leave it as it is. To clarify:

"Body" is intended to be an implementation concept that should remain hidden from model clients.

"Source element info" is a client concept and may expose only a subset of information from the actual "body" (in principle, at least).
 
> * in SourceElement.getelementAt, it's a bit simpler to use
>  ISourceElement found =
> 
>                 getElementAt(children[i], position, base);
> as base equals info.getSnapshot() at that place

I agree with you on this one. It's simpler and more clear. Thanks!

Best regards,
Vladimir