Re: [glassfish-dev] @Version field support seems to be ignored by Eclips

[Arjan Tijms <arjan.tijms@xxxxxxxxxxx>]

Hi,

Yes indeed. The entire 8.0 branch could (should) be merged into 8.0-JDK17 again. I just haven't found the time for it yet,

Meanwhile, the persistence TCK should work with JDK 21 as well, so maybe it's an option to use JDK 21 in the meantime?

Kind regards,

Arjan Tijms

On Wed, 9 Apr 2025 at 20:54, Scott Marlow <smarlow@xxxxxxxxxx> wrote:

It looks like https://github.com/eclipse-ee4j/glassfish/blob/8.0/appserver/pom.xml#L117 already has  `<eclipselink.version>5.0.0-B07</eclipselink.version>`, so could that be merged to the 8.0-JDK1 branch as well?

On Wed, Apr 9, 2025 at 2:40 PM Arjan Tijms <arjan.tijms@xxxxxxxxxxx> wrote:

Hi,

Unfortunately that doesn't help so much.

The problem is that the main branch for GlassFish 8 is "8.0". That is where we make all the changes, and then only for some releases we merge 8.0 into the 8.0-JDK17 branch.

Commits are of course highly appreciated, but they have to go into the 8.0 branch first. Otherwise we get merge issues down the line (we tried this before and it didn't work uit well).

Kind regards,

Arjan Tijms

On Wed, 9 Apr 2025 at 20:35, Scott Marlow via glassfish-dev <glassfish-dev@xxxxxxxxxxx> wrote:

Just created https://github.com/eclipse-ee4j/glassfish/pull/25447 for updating GlassFish to use the latest EclipseLink 5.0.0-B07 release in case that helps.

Scott

On Wed, Apr 9, 2025 at 2:06 PM Scott Marlow <smarlow@xxxxxxxxxx> wrote:

On Wed, Apr 9, 2025 at 1:58 PM Scott Marlow <smarlow@xxxxxxxxxx> wrote:

From debugging a Jakarta EE 11 Platform TCK test failure it looks like @Version support might not be in the EclipseLink version included in glassfish-8.0.0-M11.zip.  The tracking issue for the failure is currently platform-tck/issues/2112 [1].  I pushed an EE 11 Platform TCK change to [2] to help with reproducing the test failure.

Does EclipseLink include support for the Version Annotation?  It looks like the EclipseLink master branch had recent Version related changes for eclipselink/issues/2343 [3] but I'm not sure if that change is in glassfish-8.0.0-M11.zip yet.

The entity with the @Version is [4]:

"
@Entity
@Table(name = "A_BASIC")
@Access(AccessType.FIELD)
public class ShortClass_Field implements java.io.Serializable {

// ===========================================================
// instance variables

@Id
protected String id;

@Version
protected Short basicShort;
...
"

Note that in EE 10 the Platform TCK test manually set the basicShort property values but in response to TCK challenge 2112 [1], the code is changed to require the Persistence Provider to set the version field.  Do we need an EclipseLink tracking issue for adding EclipseLink support for automatically setting the version field?

Sorry, the accepted TCK challenge issue is https://github.com/jakartaee/persistence/issues/637

Please do advise if EclipseLink can add support for @Version properties such as shown above.

Scott

 

Thanks,

Scott

[1] https://github.com/jakartaee/platform-tck/issues/2112

[2] https://github.com/scottmarlow/jakartaee-tck/tree/persistence_versionfailure

[3] https://github.com/eclipse-ee4j/eclipselink/issues/2343

[4] https://github.com/jakartaee/platform-tck/blob/3e642738584b2e4b9a6a9d80bb12fed6b53afb7e/tcks/apis/persistence/persistence-inside-container/spec-tests/src/main/java/ee/jakarta/tck/persistence/core/annotations/version/ShortClass_Field.java#L27

_______________________________________________
glassfish-dev mailing list
glassfish-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/glassfish-dev