[
Date Prev][
Date Next][
Thread Prev][
Thread Next][
Date Index][
Thread Index]
[
List Home]
|
Re: [glassfish-dev] [External] : Re: Merge of 6.1 branch to master
|
On Feb 10, 2021, at 7:37 PM, arjan tijms <arjan.tijms@xxxxxxxxx> wrote:
>
> Hi,
>
> On Wed, Feb 10, 2021 at 7:05 PM Scott Marlow <smarlow@xxxxxxxxxx> wrote:
> Are we planning to run the TCK on the GlassFish Jenkins still?
>
> That's a very good question. I like the idea of kicking off a basic TCK test from the GF project. On the other hand, the GF CI, due to it being a collection of many projects, not just the AS, is already a little complicated (perhaps that's an understatement even).
>
> Also, the GF CI probably has less resources provisioned for it right now?
No idea :-) But I’d recommend to run TCKs at least once in a week or two weeks (Saturdays may be good option), depending on how often the codebase will be changing to have at least some feedback before RCs will start appearing. Unless there will be someone person who will run these on his “local box” reporting issues to the tracker before it’s too late…
Thanks,
—lukas
>
> Kind regards,
> Arjan
>
>
>
>
>
>>
>>
>> Steve
>>
>>
>>
>> From: arjan tijms <arjan.tijms@xxxxxxxxx>
>> Sent: 10 February 2021 11:15
>> To: Steve Millidge (Payara) <steve.millidge@xxxxxxxxxxx>
>> Cc: glassfish developer discussions <glassfish-dev@xxxxxxxxxxx>
>> Subject: Re: Merge of 6.1 branch to master
>>
>>
>>
>> Hi,
>>
>>
>>
>> Thanks! The status is as follows:
>>
>>
>>
>> The PR includes the work done earlier by Fujitsu and my work where I updated the command security plugin to support JDK 11 and replaced all usages of sun.* classes that either disappeared entirely, or were made invisible.
>>
>>
>>
>> I tried to replace as much as possible with public alternatives. Eg “jarsigner” moved to a public API, and “FilePolicy” could be obtained via a public API. For some other code, like PropertyExpander I had to replace it with new code of myself.
>>
>>
>>
>> The code compiles, and the unit tests pass. GF starts up enough to generate the domains during the build, but beyond that no tests have been done.
>>
>>
>>
>> To be done is therefore:
>>
>>
>>
>> * Start GF manually and inspect logs
>>
>> * Start admin console and test if it all works
>>
>> * Fix the 3 CI tests:
>>
>> Cdi_all
>>
>> Quicklook full
>>
>> Quicklook web
>>
>> * Run TCK and fix failures (likely fix in both TCK and GF)
>>
>>
>>
>> Kind regards,
>>
>> Arjan Tijms
>>
>>
>>
>>
>>
>> On Wednesday, February 10, 2021, Steve Millidge (Payara) <steve.millidge@xxxxxxxxxxx> wrote:
>>
>> I’ve approved the merge of Arjan’s 6.1 branch to master JDK 11 compile by arjantijms · Pull Request #23349 · eclipse-ee4j/glassfish (github.com) @arjan tijms can you merge?
>>
>> @arjan tijms can you also give a quick summary of status of that branch and perhaps create some issues tagged with 6.1 so people can work on it?
>>
>>
>>
>> Thanks
>>
>>
>>
>> Steve
>>
>>
>>
>>
>>
>>
>>
>> _______________________________________________
>> glassfish-dev mailing list
>>
>> glassfish-dev@xxxxxxxxxxx
>>
>> To unsubscribe from this list, visit
>> https://www.eclipse.org/mailman/listinfo/glassfish-dev
> _______________________________________________
> glassfish-dev mailing list
> glassfish-dev@xxxxxxxxxxx
> To unsubscribe from this list, visit https://urldefense.com/v3/__https://www.eclipse.org/mailman/listinfo/glassfish-dev__;!!GqivPVa7Brio!MFzNrAFTPGCprCc6tpqZEB4Blxdkcr0fmEbNfkp3chXQ8NL3PRQBVc2HMAl8DC4W5rM$
