Skip to main content
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [glassfish-dev] GlassFish 6.0.0 release still on track?
Hi,

On Sat, Dec 26, 2020 at 5:21 PM <Hussain.NM@xxxxxxxxxxxxx> wrote:

Can you consider including the below PR for 3.0.1. This updates some of the dependencies to its latest version.

 

https://github.com/eclipse-ee4j/glassfish-hk2/pull/539


Running the tests for 3.0.1 (as part of the build), it doesn't seem it really likes the new ASM version:

17:50:17  [ERROR] testProxiedSingletonInContextUsingProxyCtl(org.glassfish.hk2.tests.locator.proxiable2.ProxiableTest)  Time elapsed: 0.001 s  <<< ERROR!
17:50:17  MultiException stack 1 of 2
17:50:17  java.lang.NoClassDefFoundError: Could not initialize class javassist.util.proxy.SecurityActions
17:50:17   at javassist.util.proxy.ProxyFactory.getMethods(ProxyFactory.java:1294)
17:50:17   at javassist.util.proxy.ProxyFactory.getMethods(ProxyFactory.java:1269)
17:50:17   at javassist.util.proxy.ProxyFactory.makeSortedMethodList(ProxyFactory.java:991)
17:50:17   at javassist.util.proxy.ProxyFactory.computeSignature(ProxyFactory.java:998)
17:50:17   at javassist.util.proxy.ProxyFactory.createClass(ProxyFactory.java:479)
17:50:17   at org.jvnet.hk2.internal.ProxyUtilities$4.run(ProxyUtilities.java:147)
17:50:17   at java.security.AccessController.doPrivileged(Native Method)
17:50:17   at org.jvnet.hk2.internal.ProxyUtilities.secureCreate(ProxyUtilities.java:127)
17:50:17   at org.jvnet.hk2.internal.ProxyUtilities.generateProxy(ProxyUtilities.java:193)
17:50:17   at org.jvnet.hk2.internal.Utilities.createService(Utilities.java:2075)
17:50:17   at org.jvnet.hk2.internal.ServiceHandleImpl.getService(ServiceHandleImpl.java:93)
17:50:17   at org.jvnet.hk2.internal.ServiceHandleImpl.getService(ServiceHandleImpl.java:67)
17:50:17   at org.glassfish.hk2.tests.locator.proxiable2.ProxiableTest.testProxiedSingletonInContextUsingProxyCtl(ProxiableTest.java:108)
17:50:17   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
17:50:17   at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
17:50:17   at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
17:50:17   at java.lang.reflect.Method.invoke(Method.java:498)
17:50:17   at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59)
17:50:17   at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
17:50:17   at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56)
17:50:17   at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
17:50:17   at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
17:50:17   at org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100)
17:50:17   at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366)
17:50:17   at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103)
17:50:17   at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:63)
17:50:17   at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331)
17:50:17   at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79)
17:50:17   at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329)
17:50:17   at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66)
17:50:17   at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293)
17:50:17   at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
17:50:17   at org.junit.runners.ParentRunner.run(ParentRunner.java:413)
17:50:17   at org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:365)
17:50:17   at org.apache.maven.surefire.junit4.JUnit4Provider.executeWithRerun(JUnit4Provider.java:273)
17:50:17   at org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:238)
17:50:17   at org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:159)
17:50:17   at org.apache.maven.surefire.booter.ForkedBooter.invokeProviderInSameClassLoader(ForkedBooter.java:384)
17:50:17   at org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:345)
17:50:17   at org.apache.maven.surefire.booter.ForkedBooter.execute(ForkedBooter.java:126)
17:50:17   at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:418)

Kind regards,
Arjan

 

We should probably assume though that we're indeed not going to release 6.0.0 tomorrow, so that's a small failure. But it should not be terrible as we do have the RC out.

 

Kind regards,

Arjan

 

 

 

On Mon, Dec 7, 2020 at 5:27 PM Steve Millidge (Payara) <steve.millidge@xxxxxxxxxxx> wrote:

To do that you will have to make a PR to add the JBoss repo into the GlassFish poms. I’m not sure we should build a final for staging based on that change?

 

From: arjan tijms <arjan.tijms@xxxxxxxxx>
Sent: 07 December 2020 16:20
To: Steve Millidge (Payara) <steve.millidge@xxxxxxxxxxx>
Cc: Guillaume Smet <guillaume.smet@xxxxxxxxx>; glassfish developer discussions <glassfish-dev@xxxxxxxxxxx>; Scott Stark <sstark@xxxxxxxxxx>; Scott Marlow <smarlow@xxxxxxxxxx>
Subject: Re: [glassfish-dev] GlassFish 6.0.0 release still on track?

 

Hi,

 

To release to central all dependencies should be in central indeed, but using the JBoss staging repo we can at least start running the TCK. I'm also not sure whether we make it in time, it would have been a whole lot better if we had CR1 last friday, but it is what it is.

 

Kind regards,

Arjan

 

 

 

On Mon, Dec 7, 2020 at 4:58 PM Steve Millidge (Payara) <steve.millidge@xxxxxxxxxxx> wrote:

I think we need to get into central so that source is buildable by anyone before we stage a release. Once there we can build a staged 6.0.0 to run the TCK against.

 

Personally I don’t think we will make it in time for tomorrow as the TCK will take a while to run but 6.0.0 can be staged tomorrow.

 

Steve

 

From: arjan tijms <arjan.tijms@xxxxxxxxx>
Sent: 07 December 2020 15:45
To: Guillaume Smet <guillaume.smet@xxxxxxxxx>
Cc: Steve Millidge (Payara) <steve.millidge@xxxxxxxxxxx>; glassfish developer discussions <glassfish-dev@xxxxxxxxxxx>; Scott Stark <sstark@xxxxxxxxxx>; Scott Marlow <smarlow@xxxxxxxxxx>
Subject: Re: [glassfish-dev] GlassFish 6.0.0 release still on track?

 

Hi,

 

Thanks! That's the same as my Amsterdam time ;) 

 

Steve and others, what do you think, do a release of GF 6.0 during/just before the livestream then? 

 

Meanwhile, if CR1 available in a staging repo so we can run the TCK with that?

 

Kind regards,

Arjan


Back to the top