On 12/4/18 7:54 AM, arjan tijms wrote:
Hi romain and others,
One remark, to get rid of some warnings in QuickLook I
updated the javac JDK targets from 1.5 to 1.8. Is this
okay with you? Or should it be changed to 1.7? I wasn't
entirely sure anymore what the minimal JDK version is to
test GF 5 with.
It seems fine since the GF build requires 1.8 as well.
Hi Romain,
Thanks for doing the revert for me!
I have a good idea now what might have gone wrong with
the code and will prepare a new PR.
Kind regards,
Arjan
On 12/3/18 12:22
PM, arjan tijms wrote:
Hi,
I just saw it's published in Maven central
indeed, so maybe it was just a temp hiccup when I
tried the build first :O
Kind reminder, the source of truth is the pipeline not
our local environments.
FYI I did revert the PR and the build of EE4J_8 branch
is back to normal (clean test results).
Hi Romain,
It could well be that I did something
wrong, but before the commit the branch
didn't even build. It referred to
Mojarra 2.3.3.102, which doesn't seem to
be published anywhere (at least not in a
location known by GF).
So I'm a little puzzled how the
failures can be new ones. Do you know how
GF was able to build before that PR? Where
did it get Mojarra 2.3.3.102 from?
Kind regards,
Arjan
|
