Changes checked in after review by Tom Ware.
Shaun
On 24/11/2010 9:58 AM, Shaun Smith wrote:
I've run all the Gemini JPA tests and my own smoke tests. The
only place I can find where JPAInitializer.BUNDLE_RESOURCE_PREFIX
is used is MetadataAsmFactory.buildClassMetadata(). The tests
never go down the branch that leads to it's use. Given that the
constant is defined as "" I don't see how it's useful anyway.
Shaun
On 24/11/2010 9:19 AM, Tom Ware wrote:
Hi
Shaun,
I am surprised this works without maintaining the
JPAInitializer.BUNDLE_RESOURCE_PREFIX string. There are a
couple of places in the EclipseLink metadata processing code
where we use this string to find xml files in the jar. How much
testing have you run?
-Tom
Shaun Smith wrote:
A patch is ready for review for Bug
330979 <https://bugs.eclipse.org/bugs/show_bug.cgi?id=330979>
- Support getEntry on installed bundles in PDE dev mode.
https://bugs.eclipse.org/bugs/show_bug.cgi?id=330979
Tom,
I updated your recently contributed BundleArchive class to
also make it pick up the bin path specified in the Eclipse
.classpath file. Can you review the patch to make sure you're
happy with it?
Shaun
--
Oracle <http://www.oracle.com>
Shaun Smith | Principal Product Manager
Phone: +1.905.502.3094 | Mobile: +1.416.558.6244
Oracle Fusion Middleware, TopLink
ORACLE Canada | 110 Matheson Boulevard West, Suite 100,
Mississauga, Ontario | L5R 3P4
Green Oracle <http://www.oracle.com/commitment>
Oracle is committed to developing practices and products that
help protect the environment
--
Shaun Smith | Principal Product Manager
Phone: +1.905.502.3094 | Mobile: +1.416.558.6244
Oracle Fusion Middleware, TopLink
ORACLE Canada | 110 Matheson Boulevard West, Suite 100,
Mississauga, Ontario | L5R 3P4
Oracle is committed to developing practices and
products that help protect the environment
_______________________________________________
gemini-dev mailing list
gemini-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/gemini-dev
--
Shaun Smith | Principal Product Manager
Phone: +1.905.502.3094 | Mobile: +1.416.558.6244
Oracle Fusion Middleware, TopLink
ORACLE Canada | 110 Matheson Boulevard West, Suite 100,
Mississauga, Ontario | L5R 3P4
Oracle is committed to developing practices and
products that help protect the environment
|
