RE: [geclipse-dev] Checkstyle config on packages

["Harald Kornmayer" <harald.kornmayer@xxxxxxxxxxxx>]

Hi all 

Most of the code in the sla packages are autogenerated using EMF. 

>>eu.geclipse.core.sla
>>eu.geclipse.nextgrid.sla
>>eu.geclipse.nextgrid.sla.ui

That - as we know from earlier time - does generate code
which is not "checkstyle"-compatible. I will exclude the 
them from checkstyle soon!

Harald


==========================================
Dr. Harald Kornmayer
Senior researcher

NEC Laboratories Europe 
IT Research Division
Rathausallee 10 
D-53757 Sankt Augustin
Germany

Phone: +49 2241 92 52 57 
Fax:   +49 2241 92 52 99
Email: harald.kornmayer@xxxxxxxxxxxx

NEC Europe Ltd., Registered Office: NEC House,
1 Victoria Road, London W3 6bL,
Registered in England 2832014
==========================================

 

>>-----Original Message-----
>>From: geclipse-dev-bounces@xxxxxxxxxxx 
>>[mailto:geclipse-dev-bounces@xxxxxxxxxxx] On Behalf Of Ken Meacham
>>Sent: Tuesday, August 05, 2008 11:43 AM
>>To: Developer mailing list
>>Subject: RE: [geclipse-dev] Checkstyle config on packages
>>
>>Hi Markus,
>>
>>I checked into CVS the checkstyle config for:
>>
>>eu.geclipse.core.sla
>>eu.geclipse.glite.ui
>>eu.geclipse.nextgrid.sla
>>eu.geclipse.nextgrid.sla.ui
>>
>>This produces quite a lot of new errors, so beware!
>>
>>I tried to commit changes for the following projects, but then
>>remembered I can't commit to SVN!
>>
>>eu.geclipse.aws.s3.test
>>eu.geclipse.core.reporting.test
>>eu.geclipse.doc.isv
>>eu.geclipse.info.ui
>>eu.geclipse.jsdl.ui.test
>>
>>Is there a way of me committing this, or is it easier if someone else
>>(e.g. you) makes these changes?
>>
>>Regards,
>>
>>Ken.
>>
>>
>>> -----Original Message-----
>>> From: geclipse-dev-bounces@xxxxxxxxxxx 
>>> [mailto:geclipse-dev-bounces@xxxxxxxxxxx] On Behalf Of Markus Knauer
>>> Sent: 05 August 2008 08:42
>>> To: Developer mailing list
>>> Subject: Re: [geclipse-dev] Checkstyle config on packages
>>> 
>>> Checkstyle settings don't break the PDE build (the thing that 
>>> we are running on the server as a nightly- or release-build), 
>>> so it is safe to check them in.
>>> 
>>> However, Checkstyle may create many new errors and warnings 
>>> in your workspace.
>>> 
>>> Regards, Markus
>>> 
>>> 
>>> On Monday 04 August 2008, Ken Meacham wrote:
>>> > Hi Ariel, Markus, etc,
>>> >
>>> > As I added Checkstyle configuration that was missing on a 
>>couple of 
>>> > GRIA packages in g-Eclipse, I noticed that there were quite 
>>> a number 
>>> > of other packages that were not using Checkstyle.
>>> >
>>> > So I've been through and set this up, for at least the core 
>>> g-Eclipse 
>>> > code itself (eu.geclipse.*).
>>> > There are some others, e.g. org.apache.*, which don't have 
>>> settings, 
>>> > but I wasn't sure what your policy was on those packages.
>>> >
>>> > I've checked in all the changes for packages that do not 
>>cause any 
>>> > errors (most of them, fortunately). However, the 
>>following packages 
>>> > cause many errors for me:
>>> >
>>> > eu.geclipse.core.sla
>>> > eu.geclipse.glite.ui
>>> > eu.geclipse.nextgrid.sla
>>> > eu.geclipse.nextgrid.sla.ui
>>> >
>>> > I didn't want to break any current builds, so I haven't 
>>> checked these 
>>> > in.
>>> >
>>> > Should I:
>>> >
>>> > A) Check in anyway (causing new errors in current build)
>>> > B) Check in after the M8 release
>>> > C) Leave them alone
>>> >
>>> > Cheers,
>>> >
>>> > Ken.
>>> 
>>> 
>>> 
>>> 
>>> --
>>> Markus Knauer
>>> INNOOPRACT Informationssysteme GmbH
>>> ###   phone: +49 721 664 733 0  (GMT +2)
>>> ###     fax: +49 721 664 733 29
>>> ###     web: www.innoopract.com
>>> 
>>> ========================= Legal Disclaimer 
>>> ================================= According to Section 80 of 
>>> the German Corporation Act Innoopract Informationssysteme 
>>> GmbH must indicate the following information:
>>> Address: Stephanienstrasse 20, 76133 Karlsruhe Germany 
>>> General Manager: Jochen Krause Registered Office: Karlsruhe, 
>>> Commercial Register Mannheim HRB 107883 
>>> ==============================================================
>>> ==============
>>> _______________________________________________
>>> geclipse-dev mailing list
>>> geclipse-dev@xxxxxxxxxxx
>>> https://dev.eclipse.org/mailman/listinfo/geclipse-dev
>>> 
>>_______________________________________________
>>geclipse-dev mailing list
>>geclipse-dev@xxxxxxxxxxx
>>https://dev.eclipse.org/mailman/listinfo/geclipse-dev