Re: [flux-dev] Status update

[Vershinin Fjodor <fjodor@xxxxxxxxxxxxx>]

Hi, Martin!

I had prepared gist with final evolution document, you can have a look it here: https://gist.github.com/fjodorver/b5dcfe291bebaea8f8f76fe31220177d ,

or here in google docs: https://docs.google.com/document/d/1uV9LrHkCLCF10YTaznFowoGpj9z7WQQMciPVRLl3am8

It would be nice if you can give some comments on this.

Thanks,

Fjodor

2016-08-22 10:05 GMT+03:00 Vershinin Fjodor <fjodor@xxxxxxxxxxxxx>:

Hi!

I hope you are doing extensive testing with all your changes…

Yes, sure, I test all my changes for regressions.

Btw, I have some troubles with time stamp, which I get from file system. Namely, JDK  truncates filesystem time stamp up to seconds.

For example, you can have a look here: http://stackoverflow.com/questions/24804618/get-file-mtime-with-millisecond-resolution-from-java

There are fix in open-jdk8, however, this patch is still not applied to Oracle JDK.

So, the main problem is some changes are out of sync, because after truncation some file system changes are traveling to the past. 

It can happen for example when file was deleted very fast.

I have an idea how to apply quick-fix, namely truncate millisecond part in System.currentTimeMillis(), like here:

https://github.com/fjodorver/flux/blob/2f5165fa0eac84c32dec9ffddfaa3f64a1a0533f/org.eclipse.flux.watcher/src/main/java/org/eclipse/flux/watcher/fs/JDKProjectWatchService.java#L268

What do you think?

Fjodor

--

Thanks,

Fjodor