[europa-build-workshop] Site digest generation for update site

["Kaczmarek, Pawel" <Pawel.Kaczmarek@xxxxxxxxxxxxxxxx>]

 

  Hi

  The site digest is not generated, if a feature does not contain feature.properties file. The description at http://wiki.eclipse.org/index.php/Update_Site_Optimization does not mention anything about such requirement.

  Is it a design decision or implementation problem?

  The behavior seems incoherent, since having the feature.properties file in at least one feature generates the digest for all available features on the update site.

 

  The processLocalesInJar method in org.eclipse.update.internal.provisional.SiteOptimizerApplication treats feature_xx.properties files as a specification of locales settings. The absence of any feature.properties causes locales map to be empty and, in consequence, there is no AvailableLocale object that is used to generate digest.

  It seems that runDigestBuilder should use SiteOptimizerApplication.writeFeatureDigests static method if availableLocales is empty (lines 241-244).

  A simple fix is to put new AvailableLocale("") to locales map at the end of SiteOptimizerApplication.processLocalesInJar if locales is empty (line 412).

  However, I'm not sure if this conforms to the specification of digest generation.

  Pawel

 

The contents of this e-mail are intended for the named addressee only. It contains information that may be confidential. Unless you are the named addressee or an authorized designee, you may not copy or use it, or disclose it to anyone else. If you received it in error please notify us immediately and then destroy it.