Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [europa-build-workshop] Re: [cross-project-issues-dev] CVS commit conventions / bestpractices / free benefits

Rich:

True, using the 'contributed' keyword would make querying marginally easier, but the purpose of comments like [contrib email="irbull@xxxxxxxxxx"/] in Bugzilla is to record who contributed the code associated with the bug's fix (ie., their bugzilla email address/ID) . This is just a convention we started using, but is by no means carved in stone. In many cases, the bug's submitter is also the contributor of the patch/fix, so it can be gleaned from there, but this is not true in ALL cases, so convention has been to ensure that the [contrib] comment is put in when the bug's fixed in CVS, so that there's no guesswork required 6 months later. ;-)

Cheers,

Nick

On 11/16/06, Richard Gronback <richard.gronback@xxxxxxxxxxx> wrote:
Why not use the 'contributed' keyword in bugzilla?  We use it for our IP Query in GMF.

One additional thing not mentioned in the bugs below or my original soap box is that we also employ a couple other conventions for identifying non-committer commits (NCCs). One is to use {username} in the commit comment: http://www.eclipse.org/emf/searchcvs.php?q=author%3Anickb+skrypuch+patch

The other is to provide contributor details in Bugzilla: https://bugs.eclipse.org/bugs/show_bug.cgi?id=161744#c10

This is useful when you have to concoct your project IP log - you can just query Bugzilla for "[contrib" to find all your NCCs: https://bugs.eclipse.org/bugs/buglist.cgi?query_format=advanced&classification=Tools&product=EMF&long_desc_type=allwordssubstr&long_desc=%5Bcontrib  < https://bugs.eclipse.org/bugs/buglist.cgi?query_format=advanced&amp;classification=Tools&amp;product=EMF&amp;long_desc_type=allwordssubstr&amp;long_desc=%5Bcontrib>



Back to the top