Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
[equinox-dev] Bug 475656 - RegistryStrategyOSGI is using the non-thread-safe ReferenceMap without synchronization

Hi Equinox developers,

 

I made a little patch to fix the bug described by https://bugs.eclipse.org/bugs/show_bug.cgi?id=475656 . The patch is attached to the bug report.

 

We get hit by this bug at customers running our software. The bad thing is that the unsynchronized put access to this map can lead to a map corruption which then results in an endless loop the next time the map is being accessed. Stack track then looks like this (stuck in an endless loop):

"TaskProcessor 1-10" Id=123 RUNNABLE

        at org.eclipse.core.internal.registry.ReferenceMap.get(ReferenceMap.java:280)

        at org.eclipse.core.internal.registry.osgi.RegistryStrategyOSGI.getBundle(RegistryStrategyOSGI.java:133)

        at org.eclipse.core.internal.registry.osgi.RegistryStrategyOSGI.createExecutableExtension(RegistryStrategyOSGI.java:152)

        at org.eclipse.core.internal.registry.ExtensionRegistry.createExecutableExtension(ExtensionRegistry.java:874)

        at org.eclipse.core.internal.registry.ConfigurationElement.createExecutableExtension(ConfigurationElement.java:243)

        at org.eclipse.core.internal.registry.ConfigurationElementHandle.createExecutableExtension(ConfigurationElementHandle.java:51)

        at com.agfa.pacs.core.EclipseExtensionRecord.createExtension(EclipseExtensionRecord.java:72)

 

I was hoping that one of you Equinox developers can pick this fix up an commit it for a future version of Equinox.

 

Thank you!

 

Liebe Grüße,

Hermann Czedik-Eysenberg |
Agfa HealthCare
Software Architect Image Area | HE/Architecture/Requirements - Enterprise Imaging
T  +43 1 89966 320 | F  +43 1 89966 110

Agfa HealthCare GmbH, Diefenbachgasse 35, 1150 Wien, Austria

http://www.agfahealthcare.com
http://blog.agfahealthcare.com
Geschäftsführer: Dkfm. Winfried Post | Sitz der Gesellschaft: Wien, Handelsgericht Wien, FN 56704p | UID ATU15133905
Click on link to read important disclaimer:
http://www.agfahealthcare.com/maildisclaimer

 


Back to the top