I got the supplied code working with the jetty 6.1.5 jars. Comparing it with the jetty 5 integration, I have some questions before submitting my patches:
- I see that in the current jetty 5 integration you do not directly create instances of HttpServiceServlet, but uses a internal delegate that takes care of saving and restoring the current classloader for each servlet invocation. Why is this needed?
- Also the current jetty 5 integration implements a ManagedServiceFactory from the Config Admin service, should I also implement it? How this service is used in equinox/eclipse?
- there are mixed version numbers from the bundles that import
javax.servlet: org.eclipse.equinox.http.servlet declares version [2.3.0], the current jetty 5 integration declares imports for version [2.4.0] and the new jetty 6 jars depends on version [2.5.0] and supply another javax.servlet
version. How is the best way to deal with this?
Simon Kaegi wrote: > Hi Gustavo, > >> Starting from release 6.1.5 Jetty jars will ship with OSGI manifests.
> That's great news. > >> I'm willing to integrate that with org.eclipse.equinox.http.jetty, but > That would be appreciated. Please open an enhancement request and attach > your patches
> for a starting point you might want to look at an integration with Jetty 6 > from a while back here - > https://bugs.eclipse.org/bugs/show_bug.cgi?id=132555