Skip to main content
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [emfcp-dev] Databinding 1.6 vs 1.5
Thanks, Lucas, Johannes,

I’ll see what I can do with the target, then.  In the mean-time, I won’t rush, to allow more feedback.

And I should make it clear also, for the benefit of those following this discussion but not so closely as to look at Gerrit, that what is under discussion here is on the develop branch only, targeting the 1.22 release.

How many releases back are we trying to maintain compatibility with?  I’m assuming I’ll just rev up to whatever version of DataBindings is in the Eclipse Platform repo in the TPD.

Cheers,

Christian
On May 24, 2019, 04:43 -0400, Lucas Köhler <lkoehler@xxxxxxxxxxxxxxxxx>, wrote:
Hi,

we already have quite some code that uses the generic versions of org.eclipse.core.databinding.observable.value.IObservableValue and IValueProperty. As I understand it, our code should not be compatible with 1.5 anymore anyway?

Cheers
Lucas

On Fri, 24 May 2019 at 09:29, Johannes Faltermeier <jfaltermeier@xxxxxxxxxxxxxxxxx> wrote:
Hi,

this was/is related to the introduction of generics in databinding (see https://bugs.eclipse.org/bugs/show_bug.cgi?id=497466)
Initially we delayed it to stay backward compatible for bit longer. 

As of now now updating the target will produce additional warnings, but this would be fine. So from my point of view we may update the target.

Cheers
Johannes

On Fri, 24 May 2019 at 04:04, Christian W. Damus <give.a.damus@xxxxxxxxx> wrote:
Hi, Team,

I have a JUnit test that is failing in Gerrit [1] because of a problem in our Target Platform’s adherence to the 1.5 version of the Eclipse Databinding API.  The test fails because of an exception that occurs in the rendering of control by the EnumComboViewerSWTRenderer.  The fact that this renderer is involved in the test scenario is entirely irrelevant to the purpose of the test, but nonetheless it bombs the test.

The problem is that this renderer attempts to load the ISideEffect interface that was introduced in Databindings 1.6, and so is not available in the 1.5 version that is configured in the Target Platform for the Maven build.  The consequent ClassNotFoundException bombs the test.  Strangely, in my development environment configured with the ecp.target, the PDE can “see” the 1.6 versions of the Databindings bundles and so running the test in my development environment works fine.

So, the question for the team is:
  • why is the Maven build pinned to this very old 1.5 version of the Databindings API?  It is long since out of service (it was released in 2015!)
  • would there be objection to my updating the target platform to use a more modern Databindings?
If I don’t update the target platform, I will have to update my test to render views for objects that don’t require renderers with dependency on the ISideEffect API.  But I worry that this would only postpone the inevitable:  it won’t be long before we need to run tests that have no option but to use ISideEffect-dependent code because it’s that code that they test (I’m frankly surprised that we don’t already have such tests — surely this code that requires ISideEffect is covered by the tests?).

Thanks,

Christian
_______________________________________________
emfcp-dev mailing list
emfcp-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://www.eclipse.org/mailman/listinfo/emfcp-dev


--
Johannes Faltermeier

Senior Software Engineer
EclipseSource Munich

Email: jfaltermeier@xxxxxxxxxxxxxxxxx
Web: http://eclipsesource.com/munich
Phone: +49 89 21 555 30 - 14
Fax: +49 89 21 555 30 - 19

EclipseSource Muenchen GmbH
Agnes-Pockels-Bogen 1
80992 Muenchen

General Managers: Dr. Jonas Helming, Dr. Maximilian Koegel
Registered Office: Agnes-Pockels-Bogen 1, 80992 Muenchen, Commercial
Register Muenchen, HRB 191789
_______________________________________________
emfcp-dev mailing list
emfcp-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://www.eclipse.org/mailman/listinfo/emfcp-dev


--
Lucas Köhler, M.Sc.

Software Engineer
EclipseSource Munich

Email: lkoehler@xxxxxxxxxxxxxxxxx
Web: http://eclipsesource.com/munich
Phone: +49 89 21 555 30 - 27
Fax: +49 89 21 555 30 - 19

EclipseSource München GmbH
Agnes-Pockels-Bogen 1
80992 München

General Managers: Dr. Jonas Helming, Dr. Maximilian Kögel
Registered Office: Agnes-Pockels-Bogen 1, 80992 München, Commercial Register München, HRB 191789
_______________________________________________
emfcp-dev mailing list
emfcp-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://www.eclipse.org/mailman/listinfo/emfcp-dev

Back to the top