[
Date Prev][
Date Next][
Thread Prev][
Thread Next][
Date Index][
Thread Index]
[
List Home]
|
[emfcloud-dev] Actions before merging a Pull Request and implicit contribution practices
|
- From: HEMERY Vincent <vincent.hemery@xxxxxxxxxx>
- Date: Wed, 6 Jul 2022 14:06:15 +0000
- Accept-language: fr-FR, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=csgroup.eu; dmarc=pass action=none header.from=csgroup.eu; dkim=pass header.d=csgroup.eu; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=h+p459dtdEjntHQOM3YwbNhbegxE7yvT2rsAOLTeqrY=; b=SYqOvMo7OemuRl8rlD6H3p/Nu04aDQtBoP36xsrtNJqKbt2/0tQdfV11CDRbOZ0SDRAhBpTLI887/dDwLS0WzXdvmh6XUZMsr6woC+pipO+VFy6Uwm3TXsEOs4fKs4TN42batBhFUE/6U6mGIDUORpAB3V79i2o1dsWonAD4ISongp26HtHKpFQLGwdR7T1jd4VcTAfb9UeCFjjdQ2WjViJQcLSwM4HUgARm9xxbuy5zIL02JIPwO/XwYHTRWEMyiCAkXYuJuVJOxveLCAwmnzKQr/ZR78iBipZiwMNJuo9XvrSIk9Y3127SnVeG+nlrbjw2MeaSePh4Q6fjMu2FHA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jWmDMh/8JxrLV8n+OwehteJBMe/A+Nv0sZaqk1746gLket2kAlYz4/tWh6akq8Av/hUIu0fOQJiVhZZfCJq0Ikadsi8FQJb0TPVFGJXCrTaiTVj50BNclg/H2qea+Zc1NPqM9dcuZTZSMXGL99zaYldH8hHVkKJ8soN7f6WGKlUk/nBLjQ+w78UvkfNTwtwTrhNykhukBxS4WilfK6cMpfQK+GlgSoSV97VLHxWh0A0IeeTXtU+BeKe1BcVYJn1xyJhLDOeRviuwyIOC8ARBWM/wuPkoNhgHkTBQlmvvCidtlCoEH0uRPyi5idWhX7/AQ14Um9PUp9vzfXXS0xUssA==
- Delivered-to: emfcloud-dev@xxxxxxxxxxx
- List-archive: <https://dev.eclipse.org/mailman/private/emfcloud-dev/>
- List-help: <mailto:emfcloud-dev-request@eclipse.org?subject=help>
- List-subscribe: <https://dev.eclipse.org/mailman/listinfo/emfcloud-dev>, <mailto:emfcloud-dev-request@eclipse.org?subject=subscribe>
- List-unsubscribe: <https://dev.eclipse.org/mailman/options/emfcloud-dev>, <mailto:emfcloud-dev-request@eclipse.org?subject=unsubscribe>
- Thread-index: AQHYkUGN8yr2SDm0OUGYHKmK0epSBg==
- Thread-topic: Actions before merging a Pull Request and implicit contribution practices
Hello,
I was reviewing PR
https://github.com/eclipse-emfcloud/emfjson-jackson/pull/39
Before merging any PR, I wanted to make sure it wasn't too hasty. So I have a few questions :
- As a committer, can I directly merge the PR that seems relevant to me, or should I make sure with the rest of the team that it can be inserted in the sprint's scope ? How can I check that the Eclipse Source team is not in the middle of a release process
nor in a code freeze ?
- Is there any manual action I should take regarding
https://github.com/orgs/eclipse-emfcloud/projects/2 ? Or is only the project leader in charge of it ?
- From what I have seen, the practice on the project seem to be to have at least one positive peer-review on the PR, even for committers. Can you confirm that ?
Thank you in advance for the clarifications.
Eventually these answers can be reported to the CONTRIBUTING.md files, like
https://github.com/eclipse-emfcloud/emfjson-jackson/blob/master/CONTRIBUTING.md
