Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [embed-cdt-dev] 100 Warnings & 3 Errors

TL;DR nothing needs doing for 6.0.0 in what you highlighted.

On Mon, 30 Nov 2020 at 06:00, Liviu Ionescu <ilg@xxxxxxxxxx> wrote:
Eclipse reports 100 Warnings & 3 Errors in the latest version of the source code (the 'develop-split' branch).

Most of them are related to deprecations and Java 9, but some look more concerning:

- PeripheralEnumerationCellEditor illegally extends ComboBoxCellEditor

Yes it is illegal, which means that the uses of the protected methods (createControl and focusLost) may disappear at any time without warning. However in practice it hasn't changed in years. 
- GdbMcuMemoryBlockRetrievalManager extends non-API type GdbMemoryBlockRetrievalManager

It probably should be extending MemoryBlockRetrievalManager which is provisional rather than actually internal. The GdbMemoryBlockRetrievalManager doesn't have anything the plug-ins are actually using. 

- PeripheralMemoryBlockExtension implements non-API interface IMemoryBlockUpdatePolicyProvider

This interface is technically provisional, hence non-API. Totally fine to use it. Same as above it has been provisional for >10 years.

With all the above it would be better to push improvements upstream. e.g. for the combobox it would be better to add such a mode to the platform version and for the CDT stuff it would be better to mark it officially as non-provisional. However in practice there are more important things to do.


Back to the top