Re: [elk-dev] ELK Refactoring

[LETAVERNIER Camille <Camille.LETAVERNIER@xxxxxx>]

Hi,

> Camille, you may also want to take a look at the existing diagram layout
> manager for Papyrus:

Thanks for the pointer! 

> cool! Are you going to ship that connector with Papyrus?

Yes, that's the plan (For Neon, as an extra component)

> Have you based your code on my refactored version or on master?

I've used the master branch (10e1a58) and the ELK Nightly build: http://download.eclipse.org/elk/updates/nightly

I will have a look at the refactored branch (Since the Papyrus connector is very thin, I expect the migration to be straightforward)

> If you find anything that should be improved in the
> GmfDiagramLayoutManager, also about its extensibility for subclasses,
> please let us know.

Yes, the minimal change we need is a protected method to retrieve the GMF DiagramEditor/DiagramEditPart, so that we can override it once and for all in the Papyrus connector (Currently we have to patch several locations, including big methods calling private methods, so there's a lot of copy/paste involved). I can make a patch for that

Regards,
Camille

-----Message d'origine-----
De : elk-dev-bounces@xxxxxxxxxxx [mailto:elk-dev-bounces@xxxxxxxxxxx] De la part de Christoph Daniel Schulze
Envoyé : vendredi 8 janvier 2016 09:59
À : elk-dev@xxxxxxxxxxx
Objet : Re: [elk-dev] ELK Refactoring

Hi everyone!

Camille, you may also want to take a look at the existing diagram layout
manager for Papyrus:

  http://tinyurl.com/zwzblgh

Miro, I like that change. Makes it clearer what the thing is supposed to do.

Cheers,
 Christoph Daniel

On 08/01/16 09:53, Miro Spönemann wrote:
> Hi Camille,
> 
> cool! Are you going to ship that connector with Papyrus?
> 
> Have you based your code on my refactored version or on master?
> 
> If you find anything that should be improved in the
> GmfDiagramLayoutManager, also about its extensibility for subclasses,
> please let us know.
> 
> 
> @All, an idea that just came to my mind: What about
> renaming IDiagramLayoutManager to IDiagramLayoutConnector?
> 
> Regards
>   Miro
> 
> 
>> On 07.01.2016, at 13:06, LETAVERNIER Camille
>> <Camille.LETAVERNIER@xxxxxx <mailto:Camille.LETAVERNIER@xxxxxx>> wrote:
>>
>> Hi all,
>>
>> For what it's worth, I've built a small ELK connector for Papyrus
>> editors (It required tweaking the ELK GMF Connector a little bit to
>> unwrap DiagramEditors from the Papyrus MultiDiagramEditor)
>>
>> It's probably not complete as I've not overridden all the
>> "problematic" ELK/GMF classes (Problematic from the Papyrus
>> integration point of view), but it works for the cases I've tested. So
>> if you're looking for examples, that's maybe one way to do it
>>
>> Regards,
>> Camille
> 
> 
> 
> _______________________________________________
> elk-dev mailing list
> elk-dev@xxxxxxxxxxx
> To change your delivery options, retrieve your password, or unsubscribe from this list, visit
> https://dev.eclipse.org/mailman/listinfo/elk-dev
>