Re: [egit-dev] Logical model support in EGit

[Laurent Goubet <laurent.goubet@xxxxxxx>]

Thanks Matthias,

I've finally managed to get these SWTBot tests working locally, and my latest patch sets "should" solve the test failures.

The builds triggered by these have all failed, but... :

- https://git.eclipse.org/r/#/c/13405/ : only one unrelated failure, a wrong dependency to hamcrest?
- https://git.eclipse.org/r/#/c/13404/ : three unrelated failures, two of which seem to be random SWTBot errors.
- https://git.eclipse.org/r/#/c/11966/ : This one should be re-triggered. The failures are related, but wrong : since the two aforementioned changes depend on that one, and they didn't fail, this one should not either (and the previous patch set was actually working)

These changes are no longer drafts and can be reviewed, thanks for the time :).

Laurent Goubet
Obeo

On 02/06/2013 00:51, Matthias Sohn wrote:

On Thu, May 30, 2013 at 4:41 PM, Laurent Goubet <laurent.goubet@xxxxxxx> wrote:

Hi,

Okay, I've finally gotten back to this amidst the holidays and release/build/... tasks. I've tried to limit the size of all this by splitting the tasks :

- Factorizing the comparison code, making sure we use the same code for each of the 17 actions to launch comparisons. I have submitted a second patch set on https://git.eclipse.org/r/#/c/11966/ for review.
- Enabling restrained synchronizations : I am making these changes to support the logical model; this means that EGit will launch synchronizations not only on the whole repository as it does today, but also on smaller sets of files. I have rebased https://git.eclipse.org/r/#/c/11928/ (which makes sure EGit does not fetch "too much" from the repository when synchronizing) and submitted https://git.eclipse.org/r/#/c/13404/ that allows for finer-grained restrictions on the resources included in a synchronize operation.

This second action would also allow us to provide "synchronize" actions on folders or projects instead of the sole "synchronize workspace" we have now.

I have not modified the comparisons from the commit dialog since these open comparison dialogs instead of editors. I haven't made the changes to have less "magic" comparisons with the index (compare index with head, compare with index) for now either since those will need a much more intrusive change. I'll explore Robin's suggestion on that, but it will be another commit :p.

Hudson does not seem to have been triggered by these reviews. Has it been disabled? I could not launch the SWTBot tests on my machine, so was expecting its results :).

Hudson was triggered but currently fails all EGit builds since jgit's packaging build is

packing some wrong older jgit versions coming from the eclipse platform referenced

by the packaging build. https://git.eclipse.org/r/#/c/13465/ should fix this.

--

Matthias 

begin:vcard
fn:Laurent Goubet
n:Goubet;Laurent
org:<a href="http://www.obeo.fr";>Obeo</a>
email;internet:laurent.goubet@xxxxxxx
url:http://www.obeo.fr
version:2.1
end:vcard