Re: [egit-dev] [jgit-dev] Dependency on org.hamcrest ?

[Robin Rosenberg <robin.rosenberg@xxxxxxxxxx>]

31 dec 2010 kl. 22:54 skrev Shawn Pearce:

> On Fri, Dec 31, 2010 at 13:33, Chris Aniszczyk <caniszczyk@xxxxxxxxx> wrote:
>> On Fri, Dec 31, 2010 at 3:25 PM, Shawn Pearce <spearce@xxxxxxxxxxx> wrote:
>>> Where the heck do I get org.hamcrest from for my JGit workspace?
>>> 
>>> http://wiki.eclipse.org/EGit/Contributor_Guide doesn't list it
>>> anywhere, but its now required for the JGit OSGi based build within
>>> PDE.
>> 
>> Is this for SWTBot tests?
> 
> No, its also needed by JUnit 4.  Which is what our JGit tests now use,
> even though they were perfectly OK with JUnit 3 before.  *sigh*
> 
> Its installed as part of the SWTBot stuff though, so if you install
> SWTBot (for the EGit tests) its magically there to support the JUnit 4
> tests for JGit.  Its just weird that JUnit 4 needs org.hamcrest
> imported by the *user* of the org.junit package, and not the org.junit
> package itself, or the JUnit 4 test runner.

I posted a patch to help you avoid any extra installs. I accidentally referred to the 
bundle that I got with SWTBot. Now it references the one that comes with
the Eclipse SDK, via import-package instead of require-bundle.

I also think this dependency is funky. Is this just a JUnit bug, or is there a real
reason for it.

-- robin