Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
[egit-dev] Re: [EGIT] Blame functionality update - msg#01340

2010/4/16 Manuel Woelker <manuel.woelker@xxxxxxxxx>
On Thu, Apr 15, 2010 at 1:47 PM, Matthias Sohn
<matthias.sohn@xxxxxxxxxxxxxx> wrote:
> I just came across your last year's post about blame support for EGit on the
> git list
http://osdir.com/ml/git/2009-01/msg01340.html
> Do you see a chance to port this from
http://github.com/manuel-woelker/egit/tree/blame
> to the current version of EGit which lives at Eclipse since May 2009
http://www.eclipse.org/egit/ ?
> I am scratching my itch about this still lacking feature (which you
> seemingly already
> had working last year) and am wondering if I could port it up to the latest
> version.
> Any particular reason why it didn't make it back into the project repo ?
Good to hear from you. I am glad to see that EGit is finally picking
up some steam at Eclipse.org.

The main problem with the blame functionality at the time was that it
required a diff implementation to generate Longest Common
Subsequences. I looked at a few different implementations but none
seemed like a good fit (mostly due to licensing issues).

I haven't followed EGit development all that closely in the meantime
but AFAIR Johannes Schindelin was working on such a diff
implementation.

exactly, he contributed the Myers diff to JGit so we can use that for blame also
 
As for merging it back into the current head, I would definitely like
to see that. Missing integration into Eclipse is still one of the
major hurdles to git adoption. But to be perfectly honest I currently
can't commit that much time to it.

The heuristics in the C implementation are a bit more involved, so it
would probably take a bit more work to get full functional parity in
EGit. Maybe I can get something done when I have a little downtime,
but again I don't want to promise anything. You are very welcome to
take a shot at it, and if you have any question I'll do my best to
answer them.

Cheers, and keep up the good work
 - Manuel

Ok, I will put it on my list somewhere near the top and probably come
back with some questions ;-)

We will track this endeavor in https://bugs.eclipse.org/bugs/show_bug.cgi?id=306161

--
Matthias

Back to the top