Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [egit-dev] tycho build

Thank you, Matthias.

I've tried to add my changes to,131
but for whatever reason gerrit ignored Change-Id I provided and created
new change,134. Not quite sure if I
did something wrong or if this is a gerrit bug/feature.


Sohn, Matthias wrote:
Igor Fedorenko <igor@xxxxxxxxxxxxxx> wrote:
Yes, the patch does make sense and I will appreciate if you can push it
to gerrit. Given my absolute lack of knowledge of git and gerrit (case
in point, I could not even apply the patch to my local repository), I
think this is safest and fastest way to get these changes in.

I pushed the squashed patch to gerrit at,131

Igor, please abandon your old changes this new one replaces :,126  Change Icebfffdc: partially working tycho build configuration,127  Change Ic384b918: Merge commit 'origin',129  Change Ia9f596ab: Merge commit 'origin',130  Change I6198622b: New org.sonatype.tycho groupId..,128  Change I1cd9ec0f: flipped jgit.core to manifest-first

and add whatever is pending from the comments on,128 and review the commit message again. If you need more description how to contribute have a look at
egit-dev mailing list

Back to the top