Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
RE: [egit-dev] Is org.eclipse.egit.core--All-Tests broken in 'master'?

Mykola Nikishov wrote:
> Nobody cares about broken tests. Really? Or should I just 
> slow down and
> forget about this issue? ;-) But there is no other way to be 
> sure that a
> proposed change hasn't broken anything.
> Mykola Nikishov <mn@xxxxxxxxx> writes:
> > As I can see org.eclipse.egit.core--All-Tests is broken in
> > 'master' for some time. Here are steps to reproduce:
> [...]
> > Is it only me who had caught these problems?

I can reproduce the problem that T0001_ConnectProviderOperationTest fails

	at junit.framework.Assert.assertTrue(
	at junit.framework.Assert.assertTrue(
	at org.eclipse.egit.core.op.T0001_ConnectProviderOperationTest.testNoRepository(

Stefan reported the same problem in Bugzilla

I debugged through this test and found that m)
explicitly states in line 92 "Attempted to share project without repository ignored"
(which it also passes during the test run). 

Hence I think your patch you mentioned in is ok.
I commented in Gerrit accordingly. 


Back to the top