[
Date Prev][
Date Next][
Thread Prev][
Thread Next][
Date Index][
Thread Index]
[
List Home]
RE: [egit-dev] Is org.eclipse.egit.core--All-Tests broken in 'master'?
|
Mykola Nikishov wrote:
> Nobody cares about broken tests. Really? Or should I just
> slow down and
> forget about this issue? ;-) But there is no other way to be
> sure that a
> proposed change hasn't broken anything.
>
> Mykola Nikishov <mn@xxxxxxxxx> writes:
>
> > As I can see org.eclipse.egit.core--All-Tests is broken in
> > 'master' for some time. Here are steps to reproduce:
>
> [...]
>
> > Is it only me who had caught these problems?
I can reproduce the problem that T0001_ConnectProviderOperationTest fails
junit.framework.AssertionFailedError
at junit.framework.Assert.fail(Assert.java:47)
at junit.framework.Assert.assertTrue(Assert.java:20)
at junit.framework.Assert.assertTrue(Assert.java:27)
at org.eclipse.egit.core.op.T0001_ConnectProviderOperationTest.testNoRepository(T0001_ConnectProviderOperationTest.java:44)
...
Stefan reported the same problem in Bugzilla
https://bugs.eclipse.org/bugs/show_bug.cgi?id=290676
I debugged through this test and found that ConnectProviderOperation.run(IProgressMonitor m)
explicitly states in line 92 "Attempted to share project without repository ignored"
(which it also passes during the test run).
Hence I think your patch http://egit.eclipse.org/r/93 you mentioned in
http://dev.eclipse.org/mhonarc/lists/egit-dev/msg00273.html is ok.
I commented in Gerrit accordingly.
--
Matthias