Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
RE: [egit-dev] JGit feature branding plugin

A typical approach to this is to make a single branding plug-in and have all
the features that need branding point to that.  If I recall this degrades
gracefully even if the branding plug-in is not present, and the branding is
simply lacking.  I'm not sure if JGit needs a branding plug-in if it is not
making contributions to the Eclipse UI.  Fyi, the way we do it with Mylyn is
to have a plug-in whose main function is being the branding plug-in (it's
"org.eclipse.mylyn") since we support a large number of configurations with
various plug-ins and features installed.  


Dr. Mik Kersten

> -----Original Message-----
> From: egit-dev-bounces@xxxxxxxxxxx [mailto:egit-dev-
> bounces@xxxxxxxxxxx] On Behalf Of Shawn O. Pearce
> Sent: November-03-09 6:45 PM
> To: EGit developer discussion
> Subject: Re: [egit-dev] JGit feature branding plugin
> Markus Knittig <markus@xxxxxxx> wrote:
> > On 11/03/2009 07:34 PM, Shawn O. Pearce wrote:
> > >> There is already a standalone JGit feature. AFAIK Matthias just
> wants
> > >> the JGit Feature to use the EGit branding plugin.
> > >
> > > OK, but what happens when JGit feature is installed, but EGit
> > > feature is not?  Then the EGit branding plugin isn't installed,
> > > and now the JGit feature is lacking its branding assets, isn't it?
> >
> > Right, JGit shouldn't have any dependencies to EGit.
> So Matthias is correct that the jgit-feature is misconfigured, it
> points at a non-branding plugin, but I'm also right that we don't
> want the jgit-feature to depend upon the EGit branding plugin, right?
> So we need a different change, one that adds a branding plugin to
> JGit, and directs the JGit feature to use that, right?
> --
> Shawn.
> _______________________________________________
> egit-dev mailing list
> egit-dev@xxxxxxxxxxx

Back to the top