[
Date Prev][
Date Next][
Thread Prev][
Thread Next][
Date Index][
Thread Index]
[
List Home]
Assert there are no other git repositories in a parent directories (was: [egit-dev] Is org.eclipse.egit.core--All-Tests broken in 'master'?)
|
Mykola Nikishov <mn@xxxxxxxxx> writes:
[...]
> It's time to check the same for a project nested into a git
> repository. I use a default path '${workspace_loc}/../junit-workspace'
> for that matter because it points to
> '/home/mn/workspace-1/../junit-workspace' nested into a git repository
> '/home/mn/.git'. Now you'll get a bunch of failures:
Patch http://egit.eclipse.org/r/94 asserts that there are no other git
repositories in parent directories. Tests will break if executed in the
directory nested into another git repository with a meaningful reason:
junit.framework.AssertionFailedError: parent repository found
like in the first stacktrace:
--8<---------------cut here---------------start------------->8---
org.eclipse.egit.core--All-Tests
org.eclipse.egit.core.T0003_AdaptableFileTreeIteratorTest
testFileTreeToContainerAdaptation(org.eclipse.egit.core.T0003_AdaptableFileTreeIteratorTest)
junit.framework.AssertionFailedError: parent repository found
at junit.framework.Assert.fail(Assert.java:47)
at junit.framework.Assert.assertTrue(Assert.java:20)
at org.eclipse.egit.core.test.GitTestCase.checkNotNested(GitTestCase.java:64)
at org.eclipse.egit.core.test.GitTestCase.setUp(GitTestCase.java:30)
at org.eclipse.egit.core.T0003_AdaptableFileTreeIteratorTest.setUp(T0003_AdaptableFileTreeIteratorTest.java:38)
[...]
org.eclipse.egit.core.op.T0001_ConnectProviderOperationTest
testNoRepository(org.eclipse.egit.core.op.T0001_ConnectProviderOperationTest)
org.eclipse.core.internal.resources.ResourceException: Resource '/Project-1' already exists.
at org.eclipse.core.internal.resources.Resource.checkDoesNotExist(Resource.java:298)
at org.eclipse.core.internal.resources.Resource.checkDoesNotExist(Resource.java:285)
at org.eclipse.core.internal.resources.Project.assertCreateRequirements(Project.java:32)
at org.eclipse.core.internal.resources.Project.create(Project.java:252)
at org.eclipse.core.internal.resources.Project.create(Project.java:234)
at org.eclipse.core.internal.resources.Project.create(Project.java:227)
at org.eclipse.egit.core.test.TestProject.<init>(TestProject.java:47)
at org.eclipse.egit.core.test.GitTestCase.setUp(GitTestCase.java:29)
[...]
testNewRepository(org.eclipse.egit.core.op.T0001_ConnectProviderOperationTest)
org.eclipse.core.internal.resources.ResourceException: Resource '/Project-1' already exists.
at org.eclipse.core.internal.resources.Resource.checkDoesNotExist(Resource.java:298)
at org.eclipse.core.internal.resources.Resource.checkDoesNotExist(Resource.java:285)
at org.eclipse.core.internal.resources.Project.assertCreateRequirements(Project.java:32)
at org.eclipse.core.internal.resources.Project.create(Project.java:252)
at org.eclipse.core.internal.resources.Project.create(Project.java:234)
at org.eclipse.core.internal.resources.Project.create(Project.java:227)
at org.eclipse.egit.core.test.TestProject.<init>(TestProject.java:47)
at org.eclipse.egit.core.test.GitTestCase.setUp(GitTestCase.java:29)
[...]
testNewUnsharedFile(org.eclipse.egit.core.op.T0001_ConnectProviderOperationTest)
org.eclipse.core.internal.resources.ResourceException: Resource '/Project-1' already exists.
at org.eclipse.core.internal.resources.Resource.checkDoesNotExist(Resource.java:298)
at org.eclipse.core.internal.resources.Resource.checkDoesNotExist(Resource.java:285)
at org.eclipse.core.internal.resources.Project.assertCreateRequirements(Project.java:32)
at org.eclipse.core.internal.resources.Project.create(Project.java:252)
at org.eclipse.core.internal.resources.Project.create(Project.java:234)
at org.eclipse.core.internal.resources.Project.create(Project.java:227)
at org.eclipse.egit.core.test.TestProject.<init>(TestProject.java:47)
at org.eclipse.egit.core.test.GitTestCase.setUp(GitTestCase.java:29)
[...]
org.eclipse.egit.core.internal.mapping.T0002_history
testSingleRevision_1(org.eclipse.egit.core.internal.mapping.T0002_history)
org.eclipse.core.internal.resources.ResourceException: Resource '/Project-1' already exists.
at org.eclipse.core.internal.resources.Resource.checkDoesNotExist(Resource.java:298)
at org.eclipse.core.internal.resources.Resource.checkDoesNotExist(Resource.java:285)
at org.eclipse.core.internal.resources.Project.assertCreateRequirements(Project.java:32)
at org.eclipse.core.internal.resources.Project.create(Project.java:252)
at org.eclipse.core.internal.resources.Project.create(Project.java:234)
at org.eclipse.core.internal.resources.Project.create(Project.java:227)
at org.eclipse.egit.core.test.TestProject.<init>(TestProject.java:47)
at org.eclipse.egit.core.test.GitTestCase.setUp(GitTestCase.java:29)
at org.eclipse.egit.core.internal.mapping.T0002_history.setUp(T0002_history.java:53)
[...]
testSingleRevision_2(org.eclipse.egit.core.internal.mapping.T0002_history)
org.eclipse.core.internal.resources.ResourceException: Resource '/Project-1' already exists.
at org.eclipse.core.internal.resources.Resource.checkDoesNotExist(Resource.java:298)
at org.eclipse.core.internal.resources.Resource.checkDoesNotExist(Resource.java:285)
at org.eclipse.core.internal.resources.Project.assertCreateRequirements(Project.java:32)
at org.eclipse.core.internal.resources.Project.create(Project.java:252)
at org.eclipse.core.internal.resources.Project.create(Project.java:234)
at org.eclipse.core.internal.resources.Project.create(Project.java:227)
at org.eclipse.egit.core.test.TestProject.<init>(TestProject.java:47)
at org.eclipse.egit.core.test.GitTestCase.setUp(GitTestCase.java:29)
at org.eclipse.egit.core.internal.mapping.T0002_history.setUp(T0002_history.java:53)
[...]
testSingleRevision_3(org.eclipse.egit.core.internal.mapping.T0002_history)
org.eclipse.core.internal.resources.ResourceException: Resource '/Project-1' already exists.
at org.eclipse.core.internal.resources.Resource.checkDoesNotExist(Resource.java:298)
at org.eclipse.core.internal.resources.Resource.checkDoesNotExist(Resource.java:285)
at org.eclipse.core.internal.resources.Project.assertCreateRequirements(Project.java:32)
at org.eclipse.core.internal.resources.Project.create(Project.java:252)
at org.eclipse.core.internal.resources.Project.create(Project.java:234)
at org.eclipse.core.internal.resources.Project.create(Project.java:227)
at org.eclipse.egit.core.test.TestProject.<init>(TestProject.java:47)
at org.eclipse.egit.core.test.GitTestCase.setUp(GitTestCase.java:29)
at org.eclipse.egit.core.internal.mapping.T0002_history.setUp(T0002_history.java:53)
[...]
testShallowHistory(org.eclipse.egit.core.internal.mapping.T0002_history)
org.eclipse.core.internal.resources.ResourceException: Resource '/Project-1' already exists.
at org.eclipse.core.internal.resources.Resource.checkDoesNotExist(Resource.java:298)
at org.eclipse.core.internal.resources.Resource.checkDoesNotExist(Resource.java:285)
at org.eclipse.core.internal.resources.Project.assertCreateRequirements(Project.java:32)
at org.eclipse.core.internal.resources.Project.create(Project.java:252)
at org.eclipse.core.internal.resources.Project.create(Project.java:234)
at org.eclipse.core.internal.resources.Project.create(Project.java:227)
at org.eclipse.egit.core.test.TestProject.<init>(TestProject.java:47)
at org.eclipse.egit.core.test.GitTestCase.setUp(GitTestCase.java:29)
at org.eclipse.egit.core.internal.mapping.T0002_history.setUp(T0002_history.java:53)
[...]
testDeepHistory_A(org.eclipse.egit.core.internal.mapping.T0002_history)
org.eclipse.core.internal.resources.ResourceException: Resource '/Project-1' already exists.
at org.eclipse.core.internal.resources.Resource.checkDoesNotExist(Resource.java:298)
at org.eclipse.core.internal.resources.Resource.checkDoesNotExist(Resource.java:285)
at org.eclipse.core.internal.resources.Project.assertCreateRequirements(Project.java:32)
at org.eclipse.core.internal.resources.Project.create(Project.java:252)
at org.eclipse.core.internal.resources.Project.create(Project.java:234)
at org.eclipse.core.internal.resources.Project.create(Project.java:227)
at org.eclipse.egit.core.test.TestProject.<init>(TestProject.java:47)
at org.eclipse.egit.core.test.GitTestCase.setUp(GitTestCase.java:29)
at org.eclipse.egit.core.internal.mapping.T0002_history.setUp(T0002_history.java:53)
[...]
testDeepHistory_B(org.eclipse.egit.core.internal.mapping.T0002_history)
org.eclipse.core.internal.resources.ResourceException: Resource '/Project-1' already exists.
at org.eclipse.core.internal.resources.Resource.checkDoesNotExist(Resource.java:298)
at org.eclipse.core.internal.resources.Resource.checkDoesNotExist(Resource.java:285)
at org.eclipse.core.internal.resources.Project.assertCreateRequirements(Project.java:32)
at org.eclipse.core.internal.resources.Project.create(Project.java:252)
at org.eclipse.core.internal.resources.Project.create(Project.java:234)
at org.eclipse.core.internal.resources.Project.create(Project.java:227)
at org.eclipse.egit.core.test.TestProject.<init>(TestProject.java:47)
at org.eclipse.egit.core.test.GitTestCase.setUp(GitTestCase.java:29)
at org.eclipse.egit.core.internal.mapping.T0002_history.setUp(T0002_history.java:53)
[...]
--8<---------------cut here---------------end--------------->8---
But http://egit.eclipse.org/r/94 introduces another problem: the test
project not removed by tearDown() due to error in setUp() method and
will die with:
org.eclipse.core.internal.resources.ResourceException: Resource '/Project-1' already exists.
like in the rest of failures. http://egit.eclipse.org/r/95 addresses
exactly this and introduces a new constructor TestProject(boolean). It
allows the test project to be removed during the test set up right
before creating a new one.
[...]
> Is it only me who had caught these problems?
--
MAN-UANIC