|
+1 -- The only requirement is review by another committer. I hope
that all committers realize their input is always valued. We can
always encourage that too.
-- Ed
On 1/14/2020 8:41 AM, Tom Jenkinson
wrote:
Great - thanks for the information.
Tom,
No
requirement.
Getting reviews/approvals from any committer on your
project is sufficient
-- whether they are from the same company or different.
Given
that...
It may be nice to request a review from an "outsider",
especially if the proposed change might be considered
complex or controversial.
It's always good to get outside viewpoints. Again, using
MicroProfile
as an example, if I am making changes that are "slam dunk"
for
the next release of MicroProfile, getting a review/approval
from another
IBMer is just fine. But, if I am changing the way that we
are packaging
MicroProfile, then I will request a review from an
outsider. When
I create a PR, I tend to pick several individuals as
potential reviewers
to give others an opportunity to review.
Hope this
helps.
---------------------------------------------------
Kevin Sutter
STSM, MicroProfile and Jakarta EE architect @ IBM
e-mail: sutter@xxxxxxxxxx Twitter:
@kwsutter
phone: tl-553-3620 (office), 507-253-3620 (office)
LinkedIn: https://www.linkedin.com/in/kevinwsutter
From:
Tom
Jenkinson <tom.jenkinson@xxxxxxxxxx>
To:
EE4J
PMC Discussions <ee4j-pmc@xxxxxxxxxxx>
Date:
01/14/2020
04:46
Subject:
[EXTERNAL]
[ee4j-pmc] Collaboration between contributors from same
company
Sent
by: ee4j-pmc-bounces@xxxxxxxxxxx
Hi,
Is there any requirement on what
is necessary
for committers / project leads to consider when dealing with
contributions
from someone from the same company?
As an example:
https://github.com/eclipse-ee4j/jta-api/pull/74
Scott and I work for the same
company.
Is it fine for me to add my own review, then approve and
merge his PR or
do we require input from committers from a different
company?
Many thanks,
Tom_______________________________________________
ee4j-pmc mailing list
ee4j-pmc@xxxxxxxxxxx
To change your delivery options, retrieve your password,
or unsubscribe
from this list, visit
https://www.eclipse.org/mailman/listinfo/ee4j-pmc
_______________________________________________
ee4j-pmc mailing list
ee4j-pmc@xxxxxxxxxxx
To change your delivery options, retrieve your password, or
unsubscribe from this list, visit
https://www.eclipse.org/mailman/listinfo/ee4j-pmc
_______________________________________________
ee4j-pmc mailing list
ee4j-pmc@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://www.eclipse.org/mailman/listinfo/ee4j-pmc
|
