Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [ee4j-pmc] git release tags



On Fri, 30 Nov 2018 at 00:47, Bill Shannon <bill.shannon@xxxxxxxxxx> wrote:
Tom Jenkinson wrote on 11/29/18 12:26 AM:
> I can't actually spot the discussion about annotating the tags - what was the
> "subject" of the thread to help me find it please?
"git tags naming convention?"

It was a long thread, most of which wasn't about this.

I still can't find it in the archive. I searched for "git t" in the list in the archives:


> If there is a recommendation for tag names, perhaps the following article
> could be updated to reflect it:
> https://wiki.eclipse.org/JakartaEE_New_Infra_Release_Job
> As it still adds the -RELEASE suffix and is not using annotation on the tag.
Yes, we should fix that.  Or you can!  It's a wiki!  :-)

I have just had a go at doing it but didn't complete it because there is a problem. I could change it to manipulate the script quite easily, it would be just to change:
RELEASE_TAG="${RELEASE_VERSION}-RELEASE"
git push --delete origin "${RELEASE_TAG}" && true (to git push --delete origin refs/tags/"${RELEASE_TAG}" && true)

But then we need to decide what to do with the branching:
git checkout -b ${RELEASE_VERSION}
Would create a branch with the same name due to:
RELEASE_VERSION=`echo ${SNAPSHOT_VERSION} | sed -e 's/-SNAPSHOT//'`
Which is also pushed to GitHub:
git push origin "${RELEASE_VERSION}"

On it's own that is not too bad, it's just that with GitHub when you have a branch and a tag with the same name it defaults to viewing the branch in the UI and I can't seem to find a way to force it to view the tag.

(Tomas, can you please update this page?)

> I just pushed a new JTA tag simply called 1.3.1 annotated with a basic
> message, but if there is a recommended content for the tag commit message I
> can update my CI script.
I don't think we've talked about the commit message.


Back to the top