[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [ee4j-pmc] FW: Formatter Rules Configs

We'll assume it is correct and Ivar can probably comment if that's not the case.

I've checked the file in so it can be under revision control.

 - https://github.com/eclipse-ee4j/ee4j/tree/master/codestyle

I don't use Eclipse, however, so let me know if we really need it in zip format.


-- 
David Blevins
http://twitter.com/dblevins
http://www.tomitribe.com
310-633-3852

On Oct 7, 2018, at 2:03 AM, Markus KARG <markus@xxxxxxxxxxxxxxx> wrote:

In case the ruleset is considered an offical recommendation of the PMC, I want to kindly ask the PMC to publish the attached file in the EE4J WIKI. The ZIP contains the Eclipse formatting rules donated by Arjan Tijms.
-Markus
 
From: ee4j-pmc-bounces@xxxxxxxxxxx [mailto:ee4j-pmc-bounces@xxxxxxxxxxx] On Behalf Of Markus KARG
Sent: Sonntag, 7. Oktober 2018 10:58
To: 'EE4J PMC Discussions'
Subject: Re: [ee4j-pmc] Formatter Rules Configs
 
Well.. this means that WIKI page is NOT an official recommendation of the PMCâ? Would be great if the PMC either removes that page or clearly gives it the status of an OFFICIAL recommendation, including all needed corrections or clarifications.
-Markus
 
From: ee4j-pmc-bounces@xxxxxxxxxxx [mailto:ee4j-pmc-bounces@xxxxxxxxxxx] On Behalf Of David Blevins
Sent: Sonntag, 7. Oktober 2018 09:20
To: EE4J PMC Discussions
Subject: Re: [ee4j-pmc] Formatter Rules Configs
 
Hi Markus,
 
Ivar can probably comment on where that page came from.  I suspect it's a carry over from Sun conventions in place when the code was donated.  On that note I suspect we're already in wild-wild-west territory as I saw a javadoc fix from Arjan that completely reformatted all the code and pom.xml files.  So I don't know what the convention actually is.  In particular, the code was donated with xml files at 2 spaces and java files at 4 spaces.  I'm not sure if the doc was intended to change it or was unspecific on the spacing for java vs other formats like xml or json.
 
Ideally we do have a convention the majority likes and we actually stick to and is enforced with checkstyle plugin usage.  Sharing files for IDE configuration would be a definite plus.
 
 
 
On Oct 6, 2018, at 11:49 PM, Markus KARG <markus@xxxxxxxxxxxxxxx> wrote:
 
There are recommendations for code style on https://github.com/eclipse-ee4j/ee4j/wiki/Code-Conventionsand I am pretty sure there are people having set up ready-to-use formatter rules configs for Netbeans and Eclipse IDEs. So I would be happy to find them uploaded into the WIKI to make it easier to contribute to EE4J subprojects. I'm writing this to the PMC because I assume that rules where decided by you and you already had such files at hand when deciding it. :-)
_______________________________________________
ee4j-pmc mailing list
ee4j-pmc@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/ee4j-pmc
 
<ee4j.zip>_______________________________________________
ee4j-pmc mailing list
ee4j-pmc@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/ee4j-pmc