Skip to main content
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [ee4j-build] Fwd: [eclipse-ee4j/jta-api] Jakarta release has wrong OSGi Bundle-SymbolicName (#27) 
(resend from Friday, even though this is visible in archives)

On 12/7/18 5:21 PM, Lukas Jungmann wrote:

On 12/7/18 12:17 PM, Tom Jenkinson wrote:

Thanks Lukas, that makes sense.

I have a PR for this now: https://github.com/eclipse-ee4j/jta-api/pull/28
But what I am not sure of is if my PR is valid to do. Before you mentioned before that we weren't meant to be changing the extension.name <http://extension.name>
true. This particular header has nothing to do with OSGi, so I don't think this has to change now, only the change in artifactId has been requested. If majority is changing it (=probably because it is cheaper to change it now then to keep it and do the change later), then OK, let's change it now
(https://github.com/eclipse-ee4j/jta-api/pull/7#discussion_r220259536) but that seems to be necessary to make this work?
Also, I had to disable the spec-plugin to make this work which seems unfortunate too.
luckily, sources of the spec plugin are already available under eclipse-ee4j[1], so I expect some PR to cover jakartaee specifics allowing usage of the check-module goal to be raised there pretty soon. The main "problem" there is currently the strict check for artifact id and package name to start with 'javax.'. This should be changed to check for 'jakarta.' in artifact id and 'javax.' in the package name instead. 

  I looked at a few of the repos in this list
https://github.com/eclipse-ee4j/jaxrs-api/issues/709#issuecomment-445177257 and they don't seem to be using spec (or don't have check-module goal enabled in it).
usage of the spec plugin has never been mandatory, AFAIK. It only made our life easier wrt maintaining proper versioning, being consistent with other projects and following recommendations
Also note that the PR changes the manifest in the following ways from my view of it: 
Bundle-SymbolicName: jakarta.transaction-api
Bundle-Name: jakarta.transaction API
Extension-Name: jakarta.transaction

Is that what we are trying to do?
From these 3 headers I personally do care mainly about Bundle-SymbolicName - which is the only mandatory OSGi header, typically same as artifactId. For Bundle-Name, I'm fine with what you have, for Extension-Name - I don't know what can become broken if it changes nor if it remains the same. So my personal take on this would be to not change it if I don't know what problem it solves (...even though I'm not following this in this particular case :-/) 

thanks,
--lukas

[1]: https://github.com/eclipse-ee4j/glassfish-spec-version-maven-plugin
On Fri, 7 Dec 2018 at 11:04, Lukas Jungmann <lukas.jungmann@xxxxxxxxxx <mailto:lukas.jungmann@xxxxxxxxxx>> wrote: 

    On 12/7/18 11:43 AM, Tom Jenkinson wrote:
     >
     >
     > On Thu, 6 Dec 2018 at 18:58, Bill Shannon
    <bill.shannon@xxxxxxxxxx <mailto:bill.shannon@xxxxxxxxxx>
     > <mailto:bill.shannon@xxxxxxxxxx
    <mailto:bill.shannon@xxxxxxxxxx>>> wrote:
     >
     >     I don't think that bug is critical for this release, but if
    you can
     >     release another dot-dot version of the API to fix it that
    would be
     >     great.
     >
     >
     > Do we need to go through ipzilla and start a new release review
    request
     > for this? I guess so.

    No, release review is typically not needed for micro updates (aka
    service releases), see
https://wiki.eclipse.org/Development_Resources/HOWTO/Release_Reviews#Reviews_are_Not_Required_for_Service_Releases 

    thanks,
    --lukas

     >
     >
     >     Hopefully the spec-version-maven-plugin can catch these
    errors, are
     >     you using it?
     >
     >
     > I am using that plugin:
     > https://github.com/eclipse-ee4j/jta-api/blob/master/pom.xml#L119
     >
     > It did not complain from what I could see, perhaps there is a later 
     > version of the plugin. I will look during the fix of the issue.
     >
     >
     >     Others will have to answer about the current TCK process...
     >
     >     Tom Jenkinson wrote on 12/6/18 6:56 AM:
     >>     Hi,
     >>
     >>     A user from the JTA community raised the topic of an OSGi bundle      >>     symbolic name being incorrect in the Jakarta EE JTA API release. 
     >>
     >>     Is this something I should be looking to change? I don't
    think it
     >>     was specifically raised as something to address yet?
     >>
     >>     If it is a change that must be made prior to GlassFish 5.1,
    is the
     >>     process to request a TCK run still to tag @anajosep as I did
     >>     previously [1]
     >>
     >>     Thanks,
     >>     Tom
     >>
     >>     [1]
     >>
https://github.com/eclipse-ee4j/jta-api/pull/20#issuecomment-427812952 
     >>
     >>
     >>     ---------- Forwarded message ---------
     >>     From: *rfelcman* <notifications@xxxxxxxxxx
    <mailto:notifications@xxxxxxxxxx>
     >>     <mailto:notifications@xxxxxxxxxx
    <mailto:notifications@xxxxxxxxxx>>>
     >>     Date: Thu, 6 Dec 2018 at 14:48
     >>     Subject: [eclipse-ee4j/jta-api] Jakarta release has wrong OSGi 
     >>     Bundle-SymbolicName (#27)
     >>     To: eclipse-ee4j/jta-api <jta-api@xxxxxxxxxxxxxxxxxx
    <mailto:jta-api@xxxxxxxxxxxxxxxxxx>
     >>     <mailto:jta-api@xxxxxxxxxxxxxxxxxx
    <mailto:jta-api@xxxxxxxxxxxxxxxxxx>>>
     >>     Cc: Subscribed <subscribed@xxxxxxxxxxxxxxxxxx
    <mailto:subscribed@xxxxxxxxxxxxxxxxxx>
     >>     <mailto:subscribed@xxxxxxxxxxxxxxxxxx
    <mailto:subscribed@xxxxxxxxxxxxxxxxxx>>>
     >>
     >>
     >>     Jakarta release of this API has wrong value of OSGi
     >>     Bundle-SymbolicName in MANIFEST.MF.
     >>     Current value is /javax.transaction-api/ but expected value
    could
     >>     be /jakarta.transaction-api/ .
     >>
     >>     —
     >>     You are receiving this because you are subscribed to this
    thread.
     >>     Reply to this email directly, view it on GitHub
     >>     <https://github.com/eclipse-ee4j/jta-api/issues/27>, or mute the 
     >>     thread
     >>  <https://github.com/notifications/unsubscribe-auth/AATXnNVd__PKbo2_pPRfJCNAhyZwxuPyks5u2S4rgaJpZM4ZGppR>. 
     >>
     >>
     >>     _______________________________________________
     >>     ee4j-build mailing list
     >> ee4j-build@xxxxxxxxxxx <mailto:ee4j-build@xxxxxxxxxxx>
    <mailto:ee4j-build@xxxxxxxxxxx <mailto:ee4j-build@xxxxxxxxxxx>>
     >>     To change your delivery options, retrieve your password, or
    unsubscribe from this list, visit
     >> https://www.eclipse.org/mailman/listinfo/ee4j-build
     >
     >
     >
     > _______________________________________________
     > ee4j-build mailing list
     > ee4j-build@xxxxxxxxxxx <mailto:ee4j-build@xxxxxxxxxxx>
     > To change your delivery options, retrieve your password, or
    unsubscribe from this list, visit
     > https://www.eclipse.org/mailman/listinfo/ee4j-build
     >
    _______________________________________________
    ee4j-build mailing list
    ee4j-build@xxxxxxxxxxx <mailto:ee4j-build@xxxxxxxxxxx>
    To change your delivery options, retrieve your password, or
    unsubscribe from this list, visit
    https://www.eclipse.org/mailman/listinfo/ee4j-build



_______________________________________________
ee4j-build mailing list
ee4j-build@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit 
https://www.eclipse.org/mailman/listinfo/ee4j-build

Back to the top