Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [eclipselink-dev] [External] : EclipseLink 2.7.9

Hello!

Ignore my previous email. I accidentally hit the send button early.

On Tue, Jun 8, 2021 at 10:25 AM Lukas Jungmann
<lukas.jungmann@xxxxxxxxxx> wrote:
>
> so this is perhaps what you want to double check:
> http://www.eclipse.org/downloads/download.php?file=/rt/eclipselink/milestones/3.0.2/RC1/eclipselink-plugins-3.0.2.v20210604-e7fc271759.zip
>
> reachable from https://www.eclipse.org/eclipselink/downloads/milestones.php

At first glance, it looks like this is better. I will still need to
upload to our builds to make sure everything checks out properly.

I did have two notes:

1) The individual bundle names

`eclipselink-plugins-3.0.2.v20210604-e7fc271759/org.eclipse.persistence.core_3.0.2.v202106042222.jar`

Compared to 2.7.8 from eclipse downloads.
`eclipselink-plugins-2.7.8.v20201217-ecdf3c32c4/org.eclipse.persistence.core_2.7.8.v20201217-ecdf3c32c4.jar`

Do we mean to use the qualifier "v202106042222" for 3.0.2 artifacts?
In the past, YYYY/MM/DD format seemed to be enough, to we need the
timestamp too? Also, we are not including the git hash? It was a bit
useful personally to know what commit that build matches up to.

2) The manifest `Bundle-Version`

eclipselink-plugins-3.0.2.v20210604-e7fc271759/org.eclipse.persistence.core_3.0.2.v202106042222.jar/META-INF/MANIFEST.MF:
```
    Bundle-Version: 3.0.2.SNAPSHOT
```

Compared to 3.0.2-RC1 on central.
org.eclipse.persistence.core-3.0.2-RC1.jar/META-INF/MANIFEST.MF:
```
    Bundle-Version: 3.0.2.RC1
```

Compared to 2.7.8 from eclipse downloads.
eclipselink-plugins-2.7.8.v20201217-ecdf3c32c4/org.eclipse.persistence.core_2.7.8.v20201217-ecdf3c32c4.jar/META-INF/MANIFEST.MF:
```
    Bundle-Version: 2.7.8.v20201217-ecdf3c32c4
```

Do we mean to call the 3.0.2 a SNAPSHOT? I don't know if this is wrong
per-say, but it is a difference I noticed and want to bring it up in
case it isn't supposed to look like this.

Thanks,
Will Dazey


Back to the top