Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [eclipselink-dev] [External] : EclipseLink 3.0 branch

Hello!

> What the version number in master is going to be then? Or probably better question - do we need to have master at say 3.1.x and branch for 3.0.x now?

I agree that "3.1.0" sounds like a good place-holder version for master going forward. If something happens and we want "4.0", or something like that, then we can change the version before we build. I am not really too concerned with masters version because that should be the HEAD of development and not build/released anywhere. I am more just advocating for an official "3.0" release service branch for us to commit non-breaking bug fixes into the 3.0 release.


> There is 3.0.0 tag - https://github.com/eclipse-ee4j/eclipselink/releases/tag/3.0.0 - corresponding to 3.0.0 final build. Should we need to create a branch for 3.0.x, then why not from that tag?

I do think we should create a branch for "3.0.x" for service/bug fixes and future releases of 3.0 would be incremented and built from that branch; just the same as 2.6 and 2.7 before. It appears that "releases/tag/3.0.0" is on commit "commit/3986bdbeae8e0e04e5be4a7076f2bda2ee1a09a5", which matches the maven central bundle version information I found. I see no reason we cannot create a branch from that tag since they both appear to point to the same commit.

Thanks,
Will Dazey

On Mon, Feb 8, 2021 at 1:37 PM Lukas Jungmann <lukas.jungmann@xxxxxxxxxx> wrote:
Hi,

> On Feb 8, 2021, at 8:18 PM, William Dazey <dazeydev.3@xxxxxxxxx> wrote:
>
> Hello all!
> I just noticed that I don't see a branch dedicated to release "3.0", similar to "2.7'' and "2.6". There is the branch "3.0.0-M2-RELEASE", but I'm not sure if that is meant to be the "3.0" release branch going forward. If so, I recommend we rename that branch to follow the naming convention of the previous release branches (2.6, 2.7, ect). Otherwise, I recommend that we create a new branch for 3.0, forked from master at the same commit that the initial release of EclipseLink 3.0 was released at.


What the version number in master is going to be then? Or probably better question - do we need to have master at say 3.1.x and branch for 3.0.x now?

Note that we should have 3.0.1 final around mid March (I think) for EE 9.1 and the scope of changes we can do there is rather limited (basically only improving support for SE 11 + bug fixes), so I would prefer to lower the overhead by not creating additional branch till Jakarta EE 9.1 gets out.

> https://mvnrepository.com/artifact/org.eclipse.persistence/eclipselink/3.0.0:
> org.eclipse.persistence.version.properties:
> ```
> version=3.0.0
> qualifier=v202012081010
> buildDate=20201208
> buildTime=1011
> buildRevision=3986bdbeae8e0e04e5be4a7076f2bda2ee1a09a5
> buildType=SNAPSHOT
> ```
>
> which I believe matches commit: https://github.com/eclipse-ee4j/eclipselink/commit/3986bdbeae8e0e04e5be4a7076f2bda2ee1a09a5
>

There is 3.0.0 tag - https://github.com/eclipse-ee4j/eclipselink/releases/tag/3.0.0 - corresponding to 3.0.0 final build. Should we need to create a branch for 3.0.x, then why not from that tag?

Thanks,
—lukas

> Thoughts?
>
> Thanks,
> Will Dazey
> _______________________________________________
> eclipselink-dev mailing list
> eclipselink-dev@xxxxxxxxxxx
> To unsubscribe from this list, visit https://urldefense.com/v3/__https://www.eclipse.org/mailman/listinfo/eclipselink-dev__;!!GqivPVa7Brio!PxKQl_ycAvAtnayPFwvN26D6s3Xx3-xqMaXIhDcyezybWAgMeFXJyzqYReIxVbrFHL4$

_______________________________________________
eclipselink-dev mailing list
eclipselink-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/eclipselink-dev

Back to the top