Skip to main content
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [eclipselink-dev] Which branch for bugfixes?
Hello Will,

Thank your for your fast reply. This should suffice to make me able to submit the patch.

What's funny is: When I was trying to make the patch yesterday I already thought: "This would be much easier if eclipselink had a github repo". Could it be that there is no hint to github on the project website yet?

Best regards
Alex

Am Mi., 13. Feb. 2019, 04:36 hat William Dazey <dazeydev.3@xxxxxxxxx> geschrieben:
Woops, forgot to answer your specific questions!

I recommend you fix the issue in the `master` branch and then create a port for the same fix back to the `2.7` branch. If it gets code reviewed and merged, it'll get in the next 2.7 release (perhaps someone else can chime in on when that is expected to be).

For testing, I would recommend creating a simple test in the `eclipselink.jpa.test.jse` project. You should be able to take a look at similar tests in that project and create a new package (would these be PostgreSQL specific tests?) or find similar tests and add yours in.

Thanks,
Will Dazey

On Tue, Feb 12, 2019 at 9:24 PM William Dazey <dazeydev.3@xxxxxxxxx> wrote:
Hello!
If you would like to propose a fix, you should follow this wiki guide to create a pull request on the github repository and get a code review: https://github.com/eclipse-ee4j/eclipselink/wiki/Creating-a-Pull-Request

I would recommend you take a look at other GitHub issues that are closed and mirror how they are linking everything together, like this one: https://github.com/eclipse-ee4j/eclipselink/issues/89.

Also, that wiki includes instructions on pulling down/setting up your fork and setting up a workspace so that you can more easily submit PRs! Hope this helps!

Thanks,
Will Dazey

On Tue, Feb 12, 2019 at 9:09 AM Alexander Lehmann <a.lehm@xxxxxx> wrote:
Hi,

I’d like to submit a patch for bug
https://bugs.eclipse.org/bugs/show_bug.cgi?id=535431, which branch
should I base the patch on so it will get into the next 2.7 bugfix
release? And can you maybe tell me where I could add a test for this
bug, if needed after all? Thanks in advance.

Best regards
Alexander Lehmann
_______________________________________________
eclipselink-dev mailing list
eclipselink-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://www.eclipse.org/mailman/listinfo/eclipselink-dev
_______________________________________________
eclipselink-dev mailing list
eclipselink-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://www.eclipse.org/mailman/listinfo/eclipselink-dev

Back to the top