Skip to main content
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [eclipselink-dev] Fix for 455683. Add support to automatically detect the target server.
The decision is to go with current state of art, and not do explicit Spring detection (at least not for 2.6.0). We need to make sure this is documented in the release notes, and watch out community for problems. 
 MartiNG

On 12.02.15 17:09, Rick Curtis wrote:

What is the final decision on this issue?

Thanks,
Rick
On Mon, Feb 9, 2015 at 10:19 AM, Martin Grebac <martin.grebac@xxxxxxxxxx <mailto:martin.grebac@xxxxxxxxxx>> wrote: 

    On 09.02.15 15:58, andrei ilitchev wrote:

        On 2/9/2015 3:14 AM, Martin Grebac wrote:

            On 07.02.15 22:20, Lukas Jungmann wrote:

                On 2/7/15 4:03 PM, andrei ilitchev wrote:

                    In an unrelated thread lukas.jungmann@xxxxxxxxxx
                    <mailto:lukas.jungmann@xxxxxxxxxx> wrote:
                      "we're on wls, pu is coming from spring - is
                    instance of
                    org.springframework.jdbc.datasource.SimpleDriverDataSource
                    or sth similar, check could be just for the
                    package name"


                this is what I've done:
                -I briefly went through
                http://docs.spring.io/spring/docs/current/spring-framework-reference/html/orm.html#orm-jpa
                -I took samples from
                'https://github.com/spring-projects/spring-integration-samples'
                -I configured 'basic/jpa' sample to be using
                eclipselink (see:
                https://github.com/spring-projects/spring-integration-samples/tree/master/basic/jpa)

                -I run that sample under the debugger

                => I saw that in this particular case
                PersistenceUnitInfo implementation which gets to EL is
                an instance of
                org.springframework.orm.jpa.persistenceunit.SpringPersistenceUnitInfo
                and it holds an instance of
                org.springframework.jdbc.datasource.SimpleDriverDataSource
                in nonJtaDataSource field

            Since none of us seem to be Spring expert and it seems
            there's number of ways to configure Spring - is this
            something we can rely on at least somewhat for current and
            previous Spring versions?

            From another angle - is there really just one Spring
            platform? Or the list would have to become: Spring, Spring
            in WLS, Spring in WAS, Spring in ..., WLS alone, WAS, ... .
            Plus versions.

        There is no need for Spring platform: if Spring is detected
        the only thing to be done is to disableJTA on the server platform.

     There's a premise - If Spring is detected. So far I haven't seen
    any proper way to do this, but see a lot of assumption that it is
    easy and reliable. I think otherwise. If we are even able to
    detect Spring, we would not be able to detect how it is configured
    as it can be configured in different ways.
     We are also getting closer to a release, and IMO if we go with
    the change we either have to have the Spring detector in before
    the release, or not do it at all. Introducing it after 2.6.0 would
    be just another breaking change.


     MartiNG

    _______________________________________________
    eclipselink-dev mailing list
    eclipselink-dev@xxxxxxxxxxx <mailto:eclipselink-dev@xxxxxxxxxxx>
    To change your delivery options, retrieve your password, or
    unsubscribe from this list, visit
    https://dev.eclipse.org/mailman/listinfo/eclipselink-dev




--
*Rick Curtis*


--
Martin Grebac, SW Engineering Manager
Oracle Czech, Prague

Back to the top