While I still think the Open JPA functionlity we are building
portability for is a bug. I agree we have built flexibility in
before. Assuming the changes Gordon suggests are taking into
account, I'll move my vote from a "-1" to a "0".
-Tom
On 25/07/2014 2:26 PM, gordon yorke
wrote:
Hello All,
As Andre mentioned the root issue here is that the structure of
the persistence unit configuration is incorrect but we have made
changes to EclipseLink in the past to be more flexible as users
needed. I think having a persistence unit property that
configures EclipseLink to not halt persistence unit deployment
when validating the JPQL is an acceptable approach as long as this
property is off by default and only applied by the application in
question through it's persistence.xml. If the desire is to have
an application server always set the property by default then I
think this is the wrong approach as it can lead to latent errors
in a persistence unit.
This new property is incompatible with validate-only and
EclipseLink should override this new property when performing a
validate-only deployment.
I do disagree with not adding the query if it is invalid as this
will throw a misleading exception. Instead a query should be
added that will throw an exception the indicates the JPQL is
invalid.
--Gordon
On 25/07/2014 2:57 PM, Tom Ware
wrote:
I am struggling whether this feature helps or hinders the user.
To me it is a flag that says, "don't properly validate my
persistence unit", and in the absence of an understanding of the
logic behind it, would be inclined to argue the Open JPA
functionality was a bug.
What is the reasoning that the Open JPA functionality is
desirable?
Does anyone else have an opinion?
-Tom
On 25/07/2014 12:07 PM, Rick Curtis
wrote:
My concern with changing some(all?) of the JPQL
processing to LAZY is that would typically involve some
amount of runtime locking to ensure that processing is
consistent when/if there are multiple threads all trying to
process JPQL at the same time.
My attached patch essentially just logs a warning when
bad JPQL is encountered rather than fail EM creation. Then
if someone tries to use an invalid JPQL, they will receive
a runtime exception.
_______________________________________________
eclipselink-dev mailing list
eclipselink-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/eclipselink-dev
_______________________________________________
eclipselink-dev mailing list
eclipselink-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/eclipselink-dev
_______________________________________________
eclipselink-dev mailing list
eclipselink-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/eclipselink-dev
|
