Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [eclipselink-dev] Patch for bug 319256 is available. Please review. (JavaDoc)

Hi David,

Why have you added a private constructor to PersistenceUnitProperties class?

It's pretty clear from the context of the file that it just defines some constants and instantiating it doesn't make any sense (and even if the class is instantiated there is no harm in that).

Eclipselink has a clear pattern of this kind of classes - see for instance all the other non-enum classes in org.eclipse.persistence.config package


On 2/24/2011 2:28 AM, Goerler, Adrian wrote:
Hi David,

thanks for the patch. I have added two (minor) comments to the bug.


*From:* eclipselink-dev-bounces@xxxxxxxxxxx
[mailto:eclipselink-dev-bounces@xxxxxxxxxxx] *On Behalf Of *David Minsky
*Sent:* Mittwoch, 23. Februar 2011 20:35
*To:* EclipseLink Dev
*Subject:* [eclipselink-dev] Patch for bug 319256 is available. Please
review. (JavaDoc)

*Bug 319256* <> -
Some constants in PersistenceUnitProperties are missing JavaDoc

A patch has been uploaded to the bug and is available for review.
Comments are, of course, welcome.



Oracle <>
David Minsky | Senior Member of Technical Staff
Phone: +1 613 2884605 <tel:+1%20613%202884605>
Oracle Oracle Server Technologies Sustaining Engineering
ORACLE Canada | 45 O'Connor Street, Ottawa, Ontario | K1P 1A4
Green Oracle <>Oracle is committed to
developing practices and products that help protect the environment

eclipselink-dev mailing list

Back to the top